Backport PR #14017 and #12706 into 1.8.x#14035
Merged
nicolasnoble merged 1 commit intogrpc:v1.8.xfrom Jan 16, 2018
Merged
Conversation
stanley-cheung
approved these changes
Jan 16, 2018
Contributor
|
@ZhouyihaiDing Please retitle as "Backport PR x and y into 1.8.x" and link to the PRs here so we know where the code comes from |
ZhouyihaiDing
changed the title
Contributor
|
@nicolasnoble please merge this into 1.8.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using php-fpm, channel is reused, but allocation for arguments and credentials are not freed, which will cause the memory leak. It combines 2 commits in #14017, #12706.
Can't test on Sierra 10.13.2 because it will report error:
src/core/ext/transport/chttp2/server/chttp2_server.cc:194:43: error: use of undeclared identifier 'GRPC_ARG_SERVER_HANDSHAKE_TIMEOUT_MS'