php: fix memory leak during creating channel#14017
Merged
ZhouyihaiDing merged 1 commit intogrpc:masterfrom Jan 16, 2018
Merged
Conversation
stanley-cheung
approved these changes
Jan 14, 2018
Contributor
|
Won't the conditional branch: https://github.com/ZhouyihaiDing/grpc/blob/a6f0e2482cfc7167b5ee834b0689c4f6ba0acac6/src/php/ext/grpc/channel.c#L110 also produce a memory leak? It also seems unmaintainable to have the |
ZhouyihaiDing
force-pushed
the
php_channl_memory_leak
branch
from
a6f0e24 to
b6cdfca
Compare
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is re-usable channel to be reuse, the arguments allocation for creating the channel should be freed.