Skip to content

Fix stall bug with pollhup workaround#13946

Merged
kpayson64 merged 1 commit intogrpc:v1.8.xfrom
kpayson64:fix_on_1_8
Jan 8, 2018
Merged

Fix stall bug with pollhup workaround#13946
kpayson64 merged 1 commit intogrpc:v1.8.xfrom
kpayson64:fix_on_1_8

Conversation

@kpayson64
Copy link
Copy Markdown
Contributor

@kpayson64 kpayson64 commented Jan 8, 2018

Backport #13933

@kpayson64 kpayson64 requested a review from mehrdada January 8, 2018 18:40
mehrdada
mehrdada approved these changes Jan 8, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@mehrdada mehrdada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crossing fingers.

@kpayson64 kpayson64 changed the base branch from master to v1.8.x January 8, 2018 19:29
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 8, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                           FILE SIZE
 ++++++++++++++ GROWING                             ++++++++++++++
  +0.1%     +16 src/core/lib/iomgr/ev_poll_posix.cc     +16  +0.1%
      +5.0%     +19 notify_on_locked                        +19  +5.0%

 -------------- SHRINKING                           --------------
  -0.0%     -16 [None]                                  -40  -0.0%

  [ = ]       0 TOTAL                                   -24  -0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 8, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 8, 2018 

[microbenchmarks] No significant performance differences

@kpayson64 kpayson64 merged commit b2c564a into grpc:v1.8.x Jan 8, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mehrdada mehrdada mehrdada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kpayson64 @grpc-testing @mehrdada @kokoro-team