Skip to content

Avoid stall#13933

Merged
kpayson64 merged 3 commits intogrpc:masterfrom
kpayson64:avoid_stall
Jan 8, 2018
Merged

Avoid stall#13933
kpayson64 merged 3 commits intogrpc:masterfrom
kpayson64:avoid_stall

Conversation

@kpayson64
Copy link
Copy Markdown
Contributor

@kpayson64 kpayson64 commented Jan 5, 2018 •
edited
Loading

Fixes #13918

Only the last commit is relevant (New for the roll-forward)

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 5, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++
  +0.0%      +8 [None]                                                +136  +0.0%
  +0.9%    +112 src/core/lib/iomgr/ev_poll_posix.cc                   +112  +0.9%
      +2.2%     +64 pollset_work                                           +64  +2.2%
      +9.6%     +32 fd_orphan                                              +32  +9.6%
      +4.6%     +11 fd_create                                              +11  +4.6%
      +1.6%      +5 [Unmapped]                                              +5  +1.6%
  +0.3%     +16 src/core/ext/transport/chttp2/transport/writing.cc     +16  +0.3%
       +59%     +10 [Unmapped]                                             +10   +59%
      +5.4%      +6 report_stall                                            +6  +5.4%

  +0.0%    +136 TOTAL                                                 +264  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 5, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 5, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++
  +0.0%      +8 [None]                                                +136  +0.0%
  +0.9%    +112 src/core/lib/iomgr/ev_poll_posix.cc                   +112  +0.9%
      +2.2%     +64 pollset_work                                           +64  +2.2%
      +9.6%     +32 fd_orphan                                              +32  +9.6%
      +4.6%     +11 fd_create                                              +11  +4.6%
      +1.6%      +5 [Unmapped]                                              +5  +1.6%
  +0.3%     +16 src/core/ext/transport/chttp2/transport/writing.cc     +16  +0.3%
       +59%     +10 [Unmapped]                                             +10   +59%
      +5.4%      +6 report_stall                                            +6  +5.4%

  +0.0%    +136 TOTAL                                                 +264  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 5, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 5, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 5, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 6, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++
  +0.0%      +8 [None]                                                +128  +0.0%
  +0.9%    +112 src/core/lib/iomgr/ev_poll_posix.cc                   +112  +0.9%
      +2.2%     +64 pollset_work                                           +64  +2.2%
      +9.6%     +32 fd_orphan                                              +32  +9.6%
      +4.6%     +11 fd_create                                              +11  +4.6%
      +3.1%     +10 [Unmapped]                                             +10  +3.1%
  +0.3%     +16 src/core/ext/transport/chttp2/transport/writing.cc     +16  +0.3%
       +59%     +10 [Unmapped]                                             +10   +59%
      +5.4%      +6 report_stall                                            +6  +5.4%

  +0.0%    +136 TOTAL                                                 +256  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 6, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 6, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_unary_ping_pong.BM_UnaryPingPong_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__0_8.counters.new: 1


[microbenchmarks] No significant performance differences

@kpayson64
Copy link
Copy Markdown
Contributor Author

kpayson64 commented Jan 8, 2018

#13945

@kpayson64 kpayson64 requested a review from mehrdada January 8, 2018 18:03
@kpayson64 kpayson64 merged commit b5f7e27 into grpc:master Jan 8, 2018
@kpayson64 kpayson64 mentioned this pull request Jan 8, 2018
Merged
@dhermes dhermes mentioned this pull request Jan 17, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mehrdada mehrdada mehrdada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kpayson64 @grpc-testing @mehrdada