Skip to content

Backport 13793 to 1.8.x#13921

Merged
apolcyn merged 1 commit intogrpc:v1.8.xfrom
apolcyn:backport_distribtest_fix
Jan 5, 2018
Merged

Backport 13793 to 1.8.x#13921
apolcyn merged 1 commit intogrpc:v1.8.xfrom
apolcyn:backport_distribtest_fix

Conversation

@apolcyn
Copy link
Copy Markdown
Contributor

@apolcyn apolcyn commented Jan 4, 2018

I'd like +to backport this to 1.8.x so that I can verify #13910 with the distrib tests.

@apolcyn apolcyn requested a review from mehrdada January 4, 2018 23:21
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 4, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 4, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 5, 2018 

[microbenchmarks] No significant performance differences

@apolcyn
Copy link
Copy Markdown
Contributor Author

apolcyn commented Jan 5, 2018 •
edited
Loading

test failures appear to be mostly fixed on master.
basic tests linux c: #13124
basic tests c++ linux: #12958
basic tests c++ #13430
tsan c: #13351
tsan c++: #13591
mac c++: #11116 (unimplementedrpc)

@apolcyn apolcyn merged commit 82eebaf into grpc:v1.8.x Jan 5, 2018
@apolcyn apolcyn mentioned this pull request Jan 5, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
@lock lock bot unassigned mehrdada Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mehrdada mehrdada mehrdada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lang/ruby

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apolcyn @grpc-testing @mehrdada