Skip to content

Mark tcp errors as UNAVAILABLE in UV tcp code#13917

Merged
murgatroid99 merged 1 commit intogrpc:v1.8.xfrom
murgatroid99:uv_tcp_errors_unavailable_status
Jan 5, 2018
Merged

Mark tcp errors as UNAVAILABLE in UV tcp code#13917
murgatroid99 merged 1 commit intogrpc:v1.8.xfrom
murgatroid99:uv_tcp_errors_unavailable_status

Conversation

@murgatroid99
Copy link
Copy Markdown
Member

@murgatroid99 murgatroid99 commented Jan 4, 2018

This does the same as #13771 as an attempt to deal with grpc/grpc-node#130 by making that status retryable.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 4, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 4, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 4, 2018 

[microbenchmarks] No significant performance differences

@murgatroid99
Copy link
Copy Markdown
Member Author

murgatroid99 commented Jan 4, 2018

Restarting tests because of infrastructure error on a required test job

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 4, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 4, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 5, 2018 

[microbenchmarks] No significant performance differences

@murgatroid99
Copy link
Copy Markdown
Member Author

murgatroid99 commented Jan 5, 2018

Known failures: #13124, #13923, #13381, #11116, #13351, #12510.

@murgatroid99 murgatroid99 merged commit ca8650a into grpc:v1.8.x Jan 5, 2018
@apolcyn apolcyn mentioned this pull request Jan 5, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nicolasnoble nicolasnoble nicolasnoble approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nicolasnoble nicolasnoble

Labels

area/core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@murgatroid99 @grpc-testing @nicolasnoble @kokoro-team