Skip to content

Revert "Fix a Python spinlock bug"#13898

Merged
mehrdada merged 1 commit intogrpc:masterfrom
mehrdada:revert13665
Jan 2, 2018
Merged

Revert "Fix a Python spinlock bug"#13898
mehrdada merged 1 commit intogrpc:masterfrom
mehrdada:revert13665

Conversation

@mehrdada
Copy link
Copy Markdown
Contributor

@mehrdada mehrdada commented Jan 2, 2018

This reverts commit 2df509f (PR #13665)

@grpc-testing
Copy link
Copy Markdown

****************************************************************

libgrpc.so

     VM SIZE                                           FILE SIZE
 ++++++++++++++ GROWING                             ++++++++++++++

 -------------- SHRINKING                           --------------
  -0.0%     -16 [None]                                 -144  -0.0%
  -0.9%    -112 src/core/lib/iomgr/ev_poll_posix.cc    -112  -0.9%
      -2.2%     -64 pollset_work                            -64  -2.2%
      -8.8%     -32 fd_orphan                               -32  -8.8%
      -4.4%     -11 fd_create                               -11  -4.4%
      -1.5%      -5 [Unmapped]                               -5  -1.5%

  -0.0%    -128 TOTAL                                  -256  -0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



Copy link
Copy Markdown
Contributor

@dgquintas dgquintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, this was causing failures such as this

@grpc-testing
Copy link
Copy Markdown

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

[microbenchmarks] No significant performance differences

@mehrdada
Copy link
Copy Markdown
Contributor Author

mehrdada commented Jan 2, 2018

Test failures:
macOS: Infra error--ignored
C++ Linux: #13330 #13477
Multilang Linux: #12189

@mehrdada mehrdada merged commit 69c0ff4 into grpc:master Jan 2, 2018
@mehrdada mehrdada deleted the revert13665 branch January 2, 2018 23:40
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants