Skip to content

Fix public hdrs in 1.8.x (backported bugfix)#13863

Merged
vjpai merged 1 commit intogrpc:v1.8.xfrom
vjpai:fork
Dec 22, 2017
Merged

Fix public hdrs in 1.8.x (backported bugfix)#13863
vjpai merged 1 commit intogrpc:v1.8.xfrom
vjpai:fork

Conversation

@vjpai
Copy link
Copy Markdown
Contributor

@vjpai vjpai commented Dec 21, 2017

Fixes #13862

@vjpai vjpai requested a review from mehrdada December 21, 2017 22:22
@vjpai vjpai changed the title Fix public hdrs in 1.8.x Fix public hdrs in 1.8.x (backports part of another PR) Dec 21, 2017
@vjpai vjpai changed the title Fix public hdrs in 1.8.x (backports part of another PR) Fix public hdrs in 1.8.x (backported bugfix) Dec 21, 2017
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 21, 2017 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 21, 2017 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 21, 2017 

[microbenchmarks] No significant performance differences

@vjpai vjpai merged commit b04499e into grpc:v1.8.x Dec 22, 2017
@vjpai vjpai deleted the fork branch December 22, 2017 13:44
@apolcyn apolcyn mentioned this pull request Dec 22, 2017
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mehrdada mehrdada mehrdada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vjpai @grpc-testing @mehrdada