Skip to content

Mark tcp errors as UNAVAILABLE#13771

Merged
yang-g merged 1 commit intogrpc:masterfrom
yang-g:delete
Dec 15, 2017
Merged

Mark tcp errors as UNAVAILABLE#13771
yang-g merged 1 commit intogrpc:masterfrom
yang-g:delete

Conversation

@yang-g
Copy link
Copy Markdown
Contributor

@yang-g yang-g commented Dec 14, 2017

No description provided.

@yang-g yang-g requested a review from ctiller December 14, 2017 00:40
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 14, 2017 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++

 -------------- SHRINK --------------
  [ = ]       0 [None]     -56  -0.0%

  [ = ]       0 TOTAL      -56  -0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 14, 2017 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 14, 2017 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 15, 2017 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++

 -------------- SHRINK --------------
  [ = ]       0 [None]     -48  -0.0%

  [ = ]       0 TOTAL      -48  -0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 15, 2017 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 15, 2017 

[microbenchmarks] No significant performance differences

@yang-g yang-g requested a review from ncteisen December 15, 2017 20:46
@yang-g
Copy link
Copy Markdown
Contributor Author

yang-g commented Dec 15, 2017

Test failures: #10092 #13477 #12748 #13152

@yang-g yang-g merged commit 2279cd4 into grpc:master Dec 15, 2017
@murgatroid99 murgatroid99 mentioned this pull request Jan 4, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ctiller ctiller Awaiting requested review from ctiller

1 more reviewer

@ncteisen ncteisen ncteisen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ncteisen ncteisen

@ctiller ctiller

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yang-g @grpc-testing @ncteisen @ctiller @kokoro-team