Skip to content

Delete node-related files again#13759

Merged
murgatroid99 merged 1 commit intogrpc:v1.8.xfrom
murgatroid99:node_deletion_again
Dec 15, 2017
Merged

Delete node-related files again#13759
murgatroid99 merged 1 commit intogrpc:v1.8.xfrom
murgatroid99:node_deletion_again

Conversation

@murgatroid99
Copy link
Copy Markdown
Member

@murgatroid99 murgatroid99 commented Dec 13, 2017

Delete some files that were originally deleted in #13145, but managed to come back.

Fixes #12590.

@murgatroid99 murgatroid99 requested a review from apolcyn December 13, 2017 21:48
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2017 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

1 similar comment
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2017 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2017 

[trickle] No significant performance differences

1 similar comment
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2017 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2017 

[microbenchmarks] No significant performance differences

1 similar comment
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2017 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 14, 2017 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 14, 2017 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 14, 2017 

[microbenchmarks] No significant performance differences

@murgatroid99
Copy link
Copy Markdown
Member Author

murgatroid99 commented Dec 15, 2017

Known failures: #12510, #13385, #13795.

@murgatroid99 murgatroid99 merged commit 1074cb6 into grpc:v1.8.x Dec 15, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@apolcyn apolcyn apolcyn approved these changes

Assignees

@apolcyn apolcyn

Labels

lang/node

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@murgatroid99 @grpc-testing @apolcyn @kokoro-team