Revert "Revert "All instances of exec_ctx being passed around in src/core removed""#13659
Merged
Revert "Revert "All instances of exec_ctx being passed around in src/core removed""#13659
Conversation
|
|
Contributor
|
What broke? |
|
Member
Author
|
@david nothing broke. just playing it safe, and merging it once internal builds with this change |
Member
|
FYI, I'm going to merge this into another branch to build something on top of it, so please don't rebase from now on. Thanks! |
Member
Author
|
Feel free to build on top of this. This is not going to be rebased. :) |
Merged
…n and remove grpc_exec_ctx from .pxi files in python
|
|
|
|
|
|
Member
Author
|
Known Issues #12917 |
Contributor
|
This causing issues on gcc with emutls (which the android NDK uses). if -fdata-sections is used a compile option you get the error: In file included from third_party/grpc/include/grpc/support/tls.h:57:0, |
Contributor
|
In general, being explicit about what context is used where (instead of relying on a thread_local) gives you more room (like if you want to have multiple contexts on the same thread since threads can be heavyweight). |
Member
Author
|
late reply - The above issue with data sections was fixed in #13916. As for having multiple contexts on the same threads, we have tried to conform to using a single context per thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #13658