Skip to content

Revert "All instances of exec_ctx being passed around in src/core removed"#13658

Merged
yashykt merged 1 commit intomasterfrom
revert-13058-execctx
Dec 6, 2017
Merged

Revert "All instances of exec_ctx being passed around in src/core removed"#13658
yashykt merged 1 commit intomasterfrom
revert-13058-execctx

Conversation

@yashykt
Copy link
Copy Markdown
Member

@yashykt yashykt commented Dec 6, 2017

Reverts #13058

@jtattermusch
Copy link
Copy Markdown
Contributor

Why revert?

@grpc-testing
Copy link
Copy Markdown

****************************************************************

libgrpc.so

     VM SIZE                                                                                            FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +1.6% +3.09Ki [Other]                                                                              +3.09Ki  +1.6%
  +4.3%    +592 src/core/ext/filters/client_channel/client_channel.cc                                   +592  +4.3%
      [NEW] +2.81Ki on_resolver_result_changed_locked                                                    +2.81Ki  [NEW]
      [NEW] +1.40Ki [Other]                                                                              +1.40Ki  [NEW]
      [NEW]    +984 cc_init_channel_elem                                                                    +984  [NEW]
      [NEW]    +962 pick_done_locked                                                                        +962  [NEW]
      [NEW]    +754 pick_callback_start_locked                                                              +754  [NEW]
      [NEW]    +752 cc_start_transport_stream_op_batch                                                      +752  [NEW]
      [NEW]    +666 start_transport_op_locked                                                               +666  [NEW]
      [NEW]    +611 pick_after_resolver_result_done_locked                                                  +611  [NEW]
      [NEW]    +496 watch_connectivity_state_locked                                                         +496  [NEW]
      [NEW]    +407 cc_destroy_call_elem                                                                    +407  [NEW]
      [NEW]    +365 on_external_watch_complete_locked                                                       +365  [NEW]
      [NEW]    +347 start_pick_locked                                                                       +347  [NEW]
      [NEW]    +321 waiting_for_pick_batches_fail(grpc_exec_ctx*, grpc_call_element*, grpc_error*) [clon    +321  [NEW]
      [NEW]    +297 cc_destroy_channel_elem                                                                 +297  [NEW]
      [NEW]    +237 cc_init_call_elem                                                                       +237  [NEW]
      [NEW]    +231 pick_after_resolver_result_cancel_locked                                                +231  [NEW]
      [NEW]    +230 pick_after_resolver_result_start_locked                                                 +230  [NEW]
      [NEW]    +192 set_channel_connectivity_state_locked                                                   +192  [NEW]
      [NEW]    +188 on_lb_policy_state_changed_locked                                                       +188  [NEW]
      [NEW]    +184 pick_callback_done_locked                                                               +184  [NEW]
      [NEW]    +180 grpc_client_channel_watch_connectivity_state                                            +180  [NEW]
  +1.4%    +469 src/core/ext/transport/chttp2/transport/chttp2_transport.cc                             +469  +1.4%
     +14e2% +9.11Ki [Other]                                                                              +9.11Ki +14e2%
      [NEW] +3.45Ki grpc_create_chttp2_transport                                                         +3.45Ki  [NEW]
      [NEW] +3.41Ki perform_stream_op_locked                                                             +3.41Ki  [NEW]
      [NEW] +2.37Ki grpc_chttp2_cancel_stream                                                            +2.37Ki  [NEW]
      [NEW] +1.31Ki grpc_chttp2_mark_stream_closed                                                       +1.31Ki  [NEW]
      [NEW]   +1018 read_action_locked                                                                     +1018  [NEW]
      [NEW]   +1004 grpc_chttp2_initiate_write                                                             +1004  [NEW]
      [NEW]    +987 grpc_chttp2_maybe_complete_recv_message                                                 +987  [NEW]
      [NEW]    +899 destroy_stream_locked                                                                   +899  [NEW]
      [NEW]    +743 incoming_byte_stream_next_locked                                                        +743  [NEW]
      [NEW]    +736 close_transport_locked                                                                  +736  [NEW]
      [NEW]    +690 maybe_start_some_streams                                                                +690  [NEW]
      [NEW]    +682 grpc_chttp2_complete_closure_step                                                       +682  [NEW]
      [NEW]    +637 write_action_begin_locked                                                               +637  [NEW]
      [NEW]    +618 grpc_chttp2_maybe_complete_recv_trailing_metadata                                       +618  [NEW]
      [NEW]    +594 incoming_byte_stream_pull                                                               +594  [NEW]
      [NEW]    +588 grpc_chttp2_unref_transport                                                             +588  [NEW]
      [NEW]    +495 grpc_chttp2_fake_status                                                                 +495  [NEW]
      [NEW]    +439 write_action_end_locked                                                                 +439  [NEW]
      [NEW]    +414 continue_fetching_send_locked                                                           +414  [NEW]
      [NEW]    +382 try_http_parsing(grpc_exec_ctx*, grpc_chttp2_transport*) [clone .isra.6]                +382  [NEW]
  +3.0%    +432 src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc                          +432  +3.0%
      [NEW] +1.60Ki rr_handover_locked(grpc_exec_ctx*, glb_lb_policy*) [clone .part.11]                  +1.60Ki  [NEW]
      [NEW] +1.32Ki lb_on_response_received_locked                                                       +1.32Ki  [NEW]
      [NEW] +1.28Ki query_for_backends_locked(grpc_exec_ctx*, glb_lb_policy*) [clone .part.9]            +1.28Ki  [NEW]
      [NEW] +1.24Ki [Other]                                                                              +1.24Ki  [NEW]
      [NEW]    +990 glb_create                                                                              +990  [NEW]
      [NEW]    +834 build_lb_channel_args(grpc_exec_ctx*, grpc_lb_addresses const*, grpc_fake_resolver_r    +834  [NEW]
      [NEW]    +748 glb_update_locked                                                                       +748  [NEW]
      [NEW]    +743 glb_pick_locked                                                                         +743  [NEW]
      [NEW]    +725 pick_from_internal_rr_locked                                                            +725  [NEW]
      [NEW]    +616 send_client_load_report_locked                                                          +616  [NEW]
      [NEW]    +529 glb_shutdown_locked                                                                     +529  [NEW]
      [NEW]    +460 wrapped_rr_closure                                                                      +460  [NEW]
      [NEW]    +430 lb_on_server_status_received_locked                                                     +430  [NEW]
      [NEW]    +385 maybe_restart_lb_call                                                                   +385  [NEW]
      [NEW]    +321 glb_cancel_pick_locked                                                                  +321  [NEW]
      [NEW]    +319 update_lb_connectivity_status_locked                                                    +319  [NEW]
      [NEW]    +316 glb_cancel_picks_locked                                                                 +316  [NEW]
      [NEW]    +313 glb_lb_channel_on_connectivity_changed_cb                                               +313  [NEW]
      [NEW]    +241 glb_destroy                                                                             +241  [NEW]
      [NEW]    +210 extract_backend_addresses_locked(grpc_exec_ctx*, grpc_lb_addresses const*) [clone .i    +210  [NEW]
      [NEW]    +191 lb_on_fallback_timer_locked                                                             +191  [NEW]
  +2.1%    +256 src/core/lib/iomgr/ev_poll_posix.cc                                                     +256  +2.1%
      [NEW] +2.80Ki pollset_work                                                                         +2.80Ki  [NEW]
      [NEW]    +636 pollset_kick_ext                                                                        +636  [NEW]
      [NEW]    +508 fd_end_poll                                                                             +508  [NEW]
      +129%    +395 [Other]                                                                                 +395  +129%
      [NEW]    +377 notify_on_locked                                                                        +377  [NEW]
      [NEW]    +356 fd_orphan                                                                               +356  [NEW]
      [NEW]    +242 pollset_set_add_pollset                                                                 +242  [NEW]
      [NEW]    +232 pollset_set_destroy                                                                     +232  [NEW]
      [NEW]    +231 pollset_shutdown                                                                        +231  [NEW]
      [NEW]    +226 pollset_set_add_pollset_set                                                             +226  [NEW]
      [NEW]    +222 pollset_set_add_fd                                                                      +222  [NEW]
      [NEW]    +219 pollset_set_del_pollset                                                                 +219  [NEW]
      [NEW]    +196 pollset_destroy                                                                         +196  [NEW]
      [NEW]    +194 pollset_add_fd                                                                          +194  [NEW]
      [NEW]    +183 pollset_set_del_fd                                                                      +183  [NEW]
      [NEW]    +158 finish_shutdown                                                                         +158  [NEW]
      [NEW]    +145 init_result(poll_args*) [clone .constprop.14]                                           +145  [NEW]
      [NEW]    +125 fd_shutdown                                                                             +125  [NEW]
      [NEW]    +124 unref_by(grpc_fd*, int) [clone .constprop.16]                                           +124  [NEW]
      [NEW]    +122 pollset_set_del_pollset_set                                                             +122  [NEW]
      [NEW]    +115 set_ready_locked                                                                        +115  [NEW]
  +4.2%    +240 src/core/ext/filters/client_channel/subchannel.cc                                       +240  +4.2%
      [NEW] +1.13Ki grpc_subchannel_create                                                               +1.13Ki  [NEW]
      [NEW]    +855 subchannel_connected                                                                    +855  [NEW]
      [NEW]    +361 maybe_start_connecting_locked                                                           +361  [NEW]
      [NEW]    +325 grpc_connected_subchannel_create_call                                                   +325  [NEW]
      [NEW]    +315 grpc_subchannel_notify_on_state_change                                                  +315  [NEW]
      [NEW]    +315 on_alarm                                                                                +315  [NEW]
      [NEW]    +302 grpc_subchannel_unref                                                                   +302  [NEW]
      [NEW]    +228 grpc_get_subchannel_address_arg                                                         +228  [NEW]
      [NEW]    +186 on_external_state_watcher_done                                                          +186  [NEW]
      [NEW]    +169 subchannel_on_child_state_changed                                                       +169  [NEW]
      [NEW]    +136 continue_connect_locked                                                                 +136  [NEW]
      [NEW]    +112 subchannel_destroy                                                                      +112  [NEW]
      [NEW]    +102 grpc_subchannel_weak_unref                                                              +102  [NEW]
      [NEW]     +93 grpc_connected_subchannel_notify_on_state_change                                         +93  [NEW]
      [NEW]     +92 subchannel_call_destroy                                                                  +92  [NEW]
      [NEW]     +86 grpc_subchannel_call_process_op                                                          +86  [NEW]
      [NEW]     +71 grpc_connected_subchannel_ping                                                           +71  [NEW]
      [NEW]     +46 grpc_connected_subchannel_process_transport_op                                           +46  [NEW]
      [NEW]     +18 connection_destroy                                                                       +18  [NEW]
      [NEW]      +9 grpc_subchannel_call_unref                                                                +9  [NEW]
      [NEW]      +5 [Other]                                                                                   +5  [NEW]
  +3.2%    +232 src/core/lib/iomgr/tcp_posix.cc                                                         +232  +3.2%
      [NEW]   +1012 tcp_do_read                                                                            +1012  [NEW]
      [NEW]    +983 tcp_flush                                                                               +983  [NEW]
      [NEW]    +774 grpc_tcp_create                                                                         +774  [NEW]
      [NEW]    +671 tcp_handle_read                                                                         +671  [NEW]
      [NEW]    +636 tcp_write                                                                               +636  [NEW]
      [NEW]    +551 notify_on_write                                                                         +551  [NEW]
      [NEW]    +549 run_poller                                                                              +549  [NEW]
      [NEW]    +394 tcp_drop_uncovered_then_handle_write                                                    +394  [NEW]
      [NEW]    +384 call_read_cb                                                                            +384  [NEW]
      [NEW]    +174 tcp_read                                                                                +174  [NEW]
      [NEW]    +158 tcp_read_allocation_done                                                                +158  [NEW]
      [NEW]    +134 drop_uncovered(grpc_exec_ctx*, grpc_tcp*) [clone .isra.4]                               +134  [NEW]
      [NEW]    +132 grpc_tcp_destroy_and_release_fd                                                         +132  [NEW]
      [NEW]    +121 tcp_unref                                                                               +121  [NEW]
      [NEW]    +119 notify_on_read                                                                          +119  [NEW]
      [NEW]     +82 done_poller                                                                              +82  [NEW]
      [NEW]     +49 tcp_destroy                                                                              +49  [NEW]
      [NEW]     +42 tcp_shutdown                                                                             +42  [NEW]
      [NEW]     +15 [Other]                                                                                  +15  [NEW]
      [NEW]     +15 tcp_add_to_pollset                                                                       +15  [NEW]
      [NEW]     +15 tcp_add_to_pollset_set                                                                   +15  [NEW]
  +4.7%    +224 src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc                  +224  +4.7%
      [NEW] +1.57Ki pf_connectivity_changed_locked                                                       +1.57Ki  [NEW]
      [NEW]   +1022 pf_update_locked                                                                       +1022  [NEW]
      [NEW]    +409 pf_shutdown_locked                                                                      +409  [NEW]
      [NEW]    +303 pf_cancel_picks_locked                                                                  +303  [NEW]
      [NEW]    +295 pf_cancel_pick_locked                                                                   +295  [NEW]
      [NEW]    +233 pf_destroy                                                                              +233  [NEW]
      [NEW]    +227 pf_ping_one_locked                                                                      +227  [NEW]
      [NEW]    +162 create_pick_first                                                                       +162  [NEW]
      [NEW]    +132 start_picking_locked(grpc_exec_ctx*, pick_first_lb_policy*) [clone .isra.1]             +132  [NEW]
      [NEW]    +127 pf_pick_locked                                                                          +127  [NEW]
      [NEW]    +112 pf_set_reresolve_closure_locked                                                         +112  [NEW]
      [NEW]     +97 destroy_unselected_subchannels_locked(grpc_exec_ctx*, pick_first_lb_policy*) [clone      +97  [NEW]
      [NEW]     +29 pf_exit_idle_locked                                                                      +29  [NEW]
       +20%     +23 [Unmapped]                                                                               +23   +20%
      [NEW]     +12 pf_check_connectivity_locked                                                             +12  [NEW]
      [NEW]      +9 pf_notify_on_state_change_locked                                                          +9  [NEW]
  +4.1%    +224 src/core/ext/filters/client_channel/lb_policy/round_robin/round_robin.cc                +224  +4.1%
      [NEW] +1.74Ki rr_connectivity_changed_locked                                                       +1.74Ki  [NEW]
      [NEW]    +726 rr_update_locked                                                                        +726  [NEW]
      [NEW]    +427 rr_pick_locked                                                                          +427  [NEW]
      [NEW]    +409 rr_shutdown_locked                                                                      +409  [NEW]
      [NEW]    +319 rr_cancel_picks_locked                                                                  +319  [NEW]
      [NEW]    +295 rr_cancel_pick_locked                                                                   +295  [NEW]
      [NEW]    +293 rr_ping_one_locked                                                                      +293  [NEW]
      [NEW]    +202 rr_destroy                                                                              +202  [NEW]
      [NEW]    +192 round_robin_create                                                                      +192  [NEW]
      [NEW]    +114 start_picking_locked(grpc_exec_ctx*, round_robin_lb_policy*) [clone .isra.1]            +114  [NEW]
      [NEW]    +112 rr_set_reresolve_closure_locked                                                         +112  [NEW]
      [NEW]     +29 rr_exit_idle_locked                                                                      +29  [NEW]
      [NEW]     +12 rr_check_connectivity_locked                                                             +12  [NEW]
      [NEW]      +9 rr_notify_on_state_change_locked                                                          +9  [NEW]
      +5.6%      +7 [Unmapped]                                                                                +7  +5.6%
  +7.6%    +213 src/core/lib/http/httpcli.cc                                                            +213  +7.6%
      [NEW]    +607 internal_request_begin                                                                  +607  [NEW]
      [NEW]    +591 next_address                                                                            +591  [NEW]
      [NEW]    +293 grpc_httpcli_post                                                                       +293  [NEW]
      [NEW]    +275 on_read                                                                                 +275  [NEW]
      [NEW]    +267 grpc_httpcli_get                                                                        +267  [NEW]
      [NEW]    +261 finish                                                                                  +261  [NEW]
      [NEW]    +243 on_handshake_done                                                                       +243  [NEW]
      [NEW]    +128 on_connected                                                                            +128  [NEW]
      [NEW]     +74 done_write                                                                               +74  [NEW]
      [NEW]     +66 on_resolved                                                                              +66  [NEW]
      [NEW]     +55 closure_impl::closure_wrapper                                                            +55  [NEW]
      [NEW]     +15 grpc_httpcli_set_override                                                                +15  [NEW]
       +17%     +14 [Unmapped]                                                                               +14   +17%
      [NEW]      +8 grpc_httpcli_context_destroy                                                              +8  [NEW]
      [NEW]      +3 plaintext_handshake                                                                       +3  [NEW]
  +5.4%    +208 src/core/lib/security/transport/secure_endpoint.cc                                      +208  +5.4%
      [NEW] +1.25Ki endpoint_write                                                                       +1.25Ki  [NEW]
      [NEW] +1.17Ki on_read                                                                              +1.17Ki  [NEW]
      [NEW]    +274 call_read_cb                                                                            +274  [NEW]
      [NEW]    +182 destroy                                                                                 +182  [NEW]
      [NEW]    +176 endpoint_read                                                                           +176  [NEW]
      [NEW]     +57 endpoint_destroy                                                                         +57  [NEW]
      [NEW]      +9 endpoint_shutdown                                                                         +9  [NEW]
      [NEW]      +9 endpoint_add_to_pollset                                                                   +9  [NEW]
      [NEW]      +9 endpoint_add_to_pollset_set                                                               +9  [NEW]
      [NEW]      +9 endpoint_delete_from_pollset_set                                                          +9  [NEW]
      +3.9%      +4 [Unmapped]                                                                                +4  +3.9%
  +7.6%    +192 src/core/ext/filters/client_channel/http_connect_handshaker.cc                          +192  +7.6%
      [NEW]    +849 http_connect_handshaker_do_handshake                                                    +849  [NEW]
      [NEW]    +788 on_read_done                                                                            +788  [NEW]
      [NEW]    +293 handshake_failed_locked                                                                 +293  [NEW]
      [NEW]    +219 handshaker_factory_add_handshakers                                                      +219  [NEW]
      [NEW]    +154 http_connect_handshaker_shutdown                                                        +154  [NEW]
      [NEW]    +147 on_write_done                                                                           +147  [NEW]
      [NEW]    +134 http_connect_handshaker_unref                                                           +134  [NEW]
      [NEW]      +5 http_connect_handshaker_destroy                                                           +5  [NEW]
      [NEW]      +2 handshaker_factory_destroy                                                                +2  [NEW]
      +1.0%      +1 [Unmapped]                                                                                +1  +1.0%
  +3.6%    +176 src/core/ext/filters/http/client/http_client_filter.cc                                  +176  +3.6%
      [NEW] +1.71Ki hc_start_transport_stream_op_batch                                                   +1.71Ki  [NEW]
      [NEW] +1.54Ki init_channel_elem                                                                    +1.54Ki  [NEW]
      [NEW]    +870 client_filter_incoming_metadata(grpc_exec_ctx*, grpc_call_element*, grpc_metadata_ba    +870  [NEW]
      [NEW]    +172 pull_slice_from_send_message                                                            +172  [NEW]
      [NEW]    +136 init_call_elem                                                                          +136  [NEW]
      [NEW]    +114 on_send_message_next_done                                                               +114  [NEW]
      [NEW]     +97 recv_initial_metadata_ready                                                              +97  [NEW]
      [NEW]     +97 recv_trailing_metadata_on_complete                                                       +97  [NEW]
      [NEW]     +84 send_message_on_complete                                                                 +84  [NEW]
      [NEW]     +13 destroy_channel_elem                                                                     +13  [NEW]
      [NEW]      +2 destroy_call_elem                                                                         +2  [NEW]
  +7.2%    +175 src/core/ext/transport/chttp2/server/chttp2_server.cc                                   +175  +7.2%
      [NEW]   +1015 grpc_chttp2_server_add_port                                                            +1015  [NEW]
      [NEW]    +516 on_handshake_done                                                                       +516  [NEW]
      [NEW]    +350 on_accept                                                                               +350  [NEW]
      [NEW]    +207 tcp_server_shutdown_complete                                                            +207  [NEW]
      [NEW]    +162 on_timeout                                                                              +162  [NEW]
      [NEW]     +83 server_destroy_listener                                                                  +83  [NEW]
      [NEW]     +80 server_start_listener                                                                    +80  [NEW]
      [NEW]     +71 server_connection_state_unref                                                            +71  [NEW]
      [NEW]     +51 on_receive_settings                                                                      +51  [NEW]
       +42%     +19 [Unmapped]                                                                               +19   +42%
  +3.8%    +172 src/core/lib/iomgr/udp_server.cc                                                        +172  +3.8%
      [NEW]    +840 grpc_udp_server_add_port                                                                +840  [NEW]
      [NEW]    +410 deactivated_all_ports                                                                   +410  [NEW]
      [NEW]    +391 add_socket_to_server(grpc_udp_server*, int, grpc_resolved_address const*, bool (*)(g    +391  [NEW]
      [NEW]    +369 grpc_udp_server_destroy                                                                 +369  [NEW]
      [NEW]    +338 grpc_udp_server_start                                                                   +338  [NEW]
      [NEW]    +254 on_read                                                                                 +254  [NEW]
      [NEW]    +211 do_write                                                                                +211  [NEW]
      [NEW]    +204 do_read                                                                                 +204  [NEW]
      [NEW]    +157 on_write                                                                                +157  [NEW]
      [NEW]    +154 shutdown_fd                                                                             +154  [NEW]
      [NEW]    +128 finish_shutdown                                                                         +128  [NEW]
      [NEW]     +86 destroyed_port                                                                           +86  [NEW]
      [NEW]     +71 fd_notify_on_write_wrapper                                                               +71  [NEW]
      [NEW]      +2 dummy_cb                                                                                  +2  [NEW]
  +5.2%    +172 src/core/lib/security/transport/client_auth_filter.cc                                   +172  +5.2%
      [NEW]    +921 auth_start_transport_stream_op_batch                                                    +921  [NEW]
      [NEW]    +802 on_host_checked                                                                         +802  [NEW]
      [NEW]    +519 on_credentials_metadata                                                                 +519  [NEW]
      [NEW]    +319 init_channel_elem                                                                       +319  [NEW]
      [NEW]    +122 destroy_call_elem                                                                       +122  [NEW]
      [NEW]     +66 cancel_check_call_host                                                                   +66  [NEW]
      [NEW]     +62 cancel_get_request_metadata                                                              +62  [NEW]
      [NEW]     +28 destroy_channel_elem                                                                     +28  [NEW]
       +36%     +25 [Unmapped]                                                                               +25   +36%
      [NEW]     +21 init_call_elem                                                                           +21  [NEW]
      [NEW]      +9 set_pollset_or_pollset_set                                                                +9  [NEW]
  +4.8%    +160 src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc            +160  +4.8%
      [NEW] +1.64Ki dns_ares_on_resolved_locked                                                          +1.64Ki  [NEW]
      [NEW]    +358 dns_factory_create_resolver                                                             +358  [NEW]
      [NEW]    +247 dns_ares_shutdown_locked                                                                +247  [NEW]
      [NEW]    +196 dns_ares_next_locked                                                                    +196  [NEW]
      [NEW]    +182 dns_ares_start_resolving_locked                                                         +182  [NEW]
      [NEW]    +169 dns_ares_maybe_finish_next_locked                                                       +169  [NEW]
      [NEW]    +125 dns_ares_destroy                                                                        +125  [NEW]
      [NEW]     +64 dns_ares_on_retry_timer_locked                                                           +64  [NEW]
      [NEW]     +57 dns_ares_channel_saw_error_locked                                                        +57  [NEW]
      +9.2%     +11 [Unmapped]                                                                               +11  +9.2%
  +5.0%    +160 src/core/ext/transport/chttp2/transport/frame_data.cc                                   +160  +5.0%
      [NEW] +2.11Ki grpc_deframe_unprocessed_incoming_frames                                             +2.11Ki  [NEW]
      [NEW]    +481 grpc_chttp2_data_parser_parse                                                           +481  [NEW]
      [NEW]    +152 grpc_chttp2_data_parser_destroy                                                         +152  [NEW]
       +26%     +10 [Unmapped]                                                                               +10   +26%
  +3.9%    +160 src/core/lib/security/transport/security_handshaker.cc                                  +160  +3.9%
      [NEW]    +702 on_peer_checked                                                                         +702  [NEW]
      [NEW]    +467 on_handshake_next_done_locked                                                           +467  [NEW]
      [NEW]    +407 move_read_buffer_into_handshake_buffer                                                  +407  [NEW]
      [NEW]    +341 security_handshake_failed_locked                                                        +341  [NEW]
      [NEW]    +274 on_handshake_data_sent_to_peer                                                          +274  [NEW]
      [NEW]    +260 grpc_security_handshaker_create                                                         +260  [NEW]
      [NEW]    +248 on_handshake_data_received_from_peer                                                    +248  [NEW]
      [NEW]    +188 check_peer_locked                                                                       +188  [NEW]
      [NEW]    +171 fail_handshaker_do_handshake                                                            +171  [NEW]
      [NEW]    +167 security_handshaker_unref                                                               +167  [NEW]
      [NEW]    +161 do_handshaker_next_locked                                                               +161  [NEW]
      [NEW]    +154 security_handshaker_shutdown                                                            +154  [NEW]
      [NEW]    +144 security_handshaker_do_handshake                                                        +144  [NEW]
      [NEW]     +40 client_handshaker_factory_add_handshakers                                                +40  [NEW]
      [NEW]     +40 server_handshaker_factory_add_handshakers                                                +40  [NEW]
      [NEW]      +8 fail_handshaker_destroy                                                                   +8  [NEW]
      [NEW]      +8 fail_handshaker_shutdown                                                                  +8  [NEW]
      [NEW]      +5 security_handshaker_destroy                                                               +5  [NEW]
      [NEW]      +2 handshaker_factory_destroy                                                                +2  [NEW]
  +3.0%    +144 src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.cc            +144  +3.0%
      [NEW] +1.50Ki grpc_dns_lookup_ares_impl                                                            +1.50Ki  [NEW]
      [NEW]    +373 on_dns_lookup_done_cb                                                                   +373  [NEW]
      [NEW]    +239 grpc_ares_request_unref                                                                 +239  [NEW]
      [NEW]    +133 grpc_resolve_address_ares_impl                                                          +133  [NEW]
      [NEW]     +33 grpc_cancel_ares_request                                                                 +33  [NEW]
       +29%     +21 [Unmapped]                                                                               +21   +29%
  +8.8%    +144 src/core/ext/transport/chttp2/client/chttp2_connector.cc                                +144  +8.8%
      [NEW]    +555 connected                                                                               +555  [NEW]
      [NEW]    +503 on_handshake_done                                                                       +503  [NEW]
      [NEW]    +414 chttp2_connector_connect                                                                +414  [NEW]
      [NEW]    +133 chttp2_connector_shutdown                                                               +133  [NEW]
      [NEW]     +72 chttp2_connector_unref                                                                   +72  [NEW]
       +20%      +7 [Unmapped]                                                                                +7   +20%

 -------------- SHRINKING                                                                            --------------
  -3.4% -1.76Ki [Other]                                                                              -1.76Ki  -3.4%
 -17.4%    -830 src/core/lib/debug/stats_data.cc                                                        -830 -17.4%
      [DEL]    -363 grpc_stats_inc_tcp_read_size                                                            -363  [DEL]
      [DEL]    -363 grpc_stats_inc_tcp_read_offer                                                           -363  [DEL]
      [DEL]    -363 grpc_stats_inc_tcp_write_size                                                           -363  [DEL]
      [DEL]    -363 grpc_stats_inc_server_cqs_checked                                                       -363  [DEL]
      [DEL]    -363 grpc_stats_inc_tcp_write_iov_size                                                       -363  [DEL]
      [DEL]    -363 grpc_stats_inc_http2_send_message_size                                                  -363  [DEL]
      [DEL]    -363 grpc_stats_inc_tcp_read_offer_iov_size                                                  -363  [DEL]
      [DEL]    -363 grpc_stats_inc_http2_send_flowctl_per_write                                             -363  [DEL]
      [DEL]    -363 grpc_stats_inc_http2_send_message_per_write                                             -363  [DEL]
      [DEL]    -363 grpc_stats_inc_http2_send_initial_metadata_per_write                                    -363  [DEL]
      [DEL]    -363 grpc_stats_inc_http2_send_trailing_metadata_per_write                                   -363  [DEL]
      [DEL]    -360 grpc_stats_inc_poll_events_returned                                                     -360  [DEL]
      [DEL]    -342 grpc_stats_inc_call_initial_size                                                        -342  [DEL]
     -45.6%     -31 [Unmapped]                                                                               -31 -45.6%
  -8.9%    -725 src/core/lib/surface/completion_queue.cc                                                -725  -8.9%
      [DEL]    -576 cq_end_op_for_next                                                                      -576  [DEL]
      [DEL]    -528 cq_end_op_for_pluck                                                                     -528  [DEL]
      [DEL]    -392 non_polling_poller_work                                                                 -392  [DEL]
      [DEL]    -294 ExecCtxPluck::CheckReadyToFinish                                                        -294  [DEL]
     -14.0%    -160 cq_next                                                                                 -160 -14.0%
      [DEL]    -159 ExecCtxNext::CheckReadyToFinish                                                         -159  [DEL]
     -11.6%    -158 cq_pluck                                                                                -158 -11.6%
      [DEL]    -156 cq_finish_shutdown_pluck                                                                -156  [DEL]
      [DEL]    -145 cq_finish_shutdown_next                                                                 -145  [DEL]
     -30.6%    -135 cq_event_queue_pop                                                                      -135 -30.6%
     -44.4%    -122 grpc_completion_queue_shutdown                                                          -122 -44.4%
      [DEL]    -121 non_polling_poller_shutdown                                                             -121  [DEL]
     -25.1%    -108 grpc_completion_queue_create_internal                                                   -108 -25.1%
     -24.5%    -106 grpc_completion_queue_thread_local_cache_flush                                          -106 -24.5%
     -39.9%    -105 grpc_completion_queue_destroy                                                           -105 -39.9%
      [DEL]     -74 cq_shutdown_next                                                                         -74  [DEL]
      [DEL]     -74 cq_shutdown_pluck                                                                        -74  [DEL]
      [DEL]     -60 non_polling_poller_kick                                                                  -60  [DEL]
      [DEL]     -56 grpc_cq_internal_unref                                                                   -56  [DEL]
      [DEL]     -10 [Other]                                                                                  -10  [DEL]
      [DEL]      -7 grpc_cq_end_op                                                                            -7  [DEL]
  -8.7%    -480 src/core/lib/surface/channel.cc                                                         -480  -8.7%
      [DEL] -1.48Ki grpc_channel_create_with_builder                                                     -1.48Ki  [DEL]
      [DEL]    -422 grpc_channel_create_call_internal                                                       -422  [DEL]
      [DEL]    -348 grpc_channel_create_pollset_set_call                                                    -348  [DEL]
      [DEL]    -206 grpc_channel_get_reffed_status_elem                                                     -206  [DEL]
     -19.0%    -128 grpc_channel_register_call                                                              -128 -19.0%
     -32.3%    -122 grpc_channel_destroy                                                                    -122 -32.3%
     -20.1%    -120 grpc_channel_create_call                                                                -120 -20.1%
      [DEL]    -115 grpc_channel_create                                                                     -115  [DEL]
      [DEL]    -115 destroy_channel                                                                         -115  [DEL]
     -48.3%    -111 grpc_channel_get_info                                                                   -111 -48.3%
     -21.5%    -105 grpc_channel_create_registered_call                                                     -105 -21.5%
     -32.5%     -41 [Unmapped]                                                                               -41 -32.5%
      [DEL]      -9 grpc_channel_internal_unref                                                               -9  [DEL]
  -3.5%    -480 src/core/lib/surface/server.cc                                                          -480  -3.5%
     -34.4% -1.14Ki [Other]                                                                              -1.14Ki -34.4%
      [DEL] -1.13Ki grpc_server_setup_transport                                                          -1.13Ki  [DEL]
      [DEL]    -818 got_initial_metadata                                                                    -818  [DEL]
      [DEL]    -607 maybe_finish_shutdown                                                                   -607  [DEL]
      [DEL]    -601 publish_call(grpc_server*, call_data*, unsigned long, requested_call*) [clone .isra.    -601  [DEL]
      [DEL]    -578 publish_new_rpc                                                                         -578  [DEL]
      [DEL]    -550 server_on_recv_initial_metadata                                                         -550  [DEL]
      [DEL]    -511 queue_call_request                                                                      -511  [DEL]
      [DEL]    -431 channel_broadcaster_shutdown                                                            -431  [DEL]
      [DEL]    -402 channel_connectivity_changed                                                            -402  [DEL]
      [DEL]    -305 finish_start_new_rpc                                                                    -305  [DEL]
      [DEL]    -286 accept_stream                                                                           -286  [DEL]
      [DEL]    -269 server_unref                                                                            -269  [DEL]
      [DEL]    -229 destroy_channel_elem                                                                    -229  [DEL]
      [DEL]    -185 init_channel_elem                                                                       -185  [DEL]
      [DEL]    -162 destroy_call_elem                                                                       -162  [DEL]
     -21.2%    -152 grpc_server_request_registered_call                                                     -152 -21.2%
      [DEL]    -147 init_call_elem                                                                          -147  [DEL]
      [DEL]    -146 request_matcher_kill_requests(grpc_server*, request_matcher*, grpc_error*) [clone .i    -146  [DEL]
     -23.0%    -142 grpc_server_request_call                                                                -142 -23.0%
      [DEL]    -141 kill_pending_work_locked                                                                -141  [DEL]
 -51.5%    -464 src/core/lib/iomgr/fork_posix.cc                                                        -464 -51.5%
      [DEL]    -234 grpc_postfork_child                                                                     -234  [DEL]
     -97.8%    -221 grpc_postfork_parent                                                                    -221 -97.8%
     -32.3%    -133 grpc_prefork                                                                            -133 -32.3%
 -30.0%    -320 src/core/lib/surface/alarm.cc                                                           -320 -30.0%
      [DEL]    -242 alarm_unref(grpc_alarm*) [clone .part.2]                                                -242  [DEL]
     -34.7%    -120 grpc_alarm_set                                                                          -120 -34.7%
     -52.2%    -109 grpc_alarm_cancel                                                                       -109 -52.2%
      [DEL]     -59 alarm_cb                                                                                 -59  [DEL]
      [DEL]     -25 alarm_end_completion                                                                     -25  [DEL]
  -8.7%    -288 src/core/lib/security/credentials/google_default/google_default_credentials.cc          -288  -8.7%
      [DEL] -1.07Ki create_default_creds_from_path                                                       -1.07Ki  [DEL]
      [DEL]    -204 on_compute_engine_detection_http_response                                               -204  [DEL]
     -11.9%    -192 grpc_google_default_credentials_create                                                  -192 -11.9%
     -40.7%    -118 grpc_flush_cached_google_default_credentials                                            -118 -40.7%
     -14.9%     -10 [Unmapped]                                                                               -10 -14.9%
      [DEL]      -5 destroy_pollset                                                                           -5  [DEL]
  -9.8%    -256 src/core/lib/iomgr/combiner.cc                                                          -256  -9.8%
      [DEL]   -1012 grpc_combiner_continue_exec_ctx                                                        -1012  [DEL]
      [DEL]    -392 combiner_exec                                                                           -392  [DEL]
      [DEL]    -362 combiner_finally_exec                                                                   -362  [DEL]
      [DEL]    -170 queue_offload                                                                           -170  [DEL]
      [DEL]    -124 really_destroy                                                                          -124  [DEL]
      [DEL]    -116 grpc_combiner_unref                                                                     -116  [DEL]
      [DEL]     -66 offload                                                                                  -66  [DEL]
      [DEL]     -24 enqueue_finally                                                                          -24  [DEL]
     -25.0%     -23 [Unmapped]                                                                               -23 -25.0%
  -2.7%    -256 src/core/lib/iomgr/ev_epoll1_linux.cc                                                   -256  -2.7%
      [DEL] -3.30Ki pollset_work                                                                         -3.30Ki  [DEL]
      [DEL] -2.32Ki pollset_kick                                                                         -2.32Ki  [DEL]
      [DEL]    -597 check_neighborhood_for_available_poller(pollset_neighborhood*) [clone .isra.7]          -597  [DEL]
      [DEL]    -520 pollset_shutdown                                                                        -520  [DEL]
      [DEL]    -330 fd_orphan                                                                               -330  [DEL]
      [DEL]    -172 pollset_destroy                                                                         -172  [DEL]
      [DEL]     -94 fd_shutdown_internal                                                                     -94  [DEL]
      [DEL]     -60 pollset_maybe_finish_shutdown                                                            -60  [DEL]
     -13.4%     -37 [Unmapped]                                                                               -37 -13.4%
      [DEL]      -9 fd_notify_on_read                                                                         -9  [DEL]
      [DEL]      -9 fd_notify_on_write                                                                        -9  [DEL]
      [DEL]      -5 fd_get_read_notifier_pollset                                                              -5  [DEL]
      [DEL]      -4 fd_shutdown                                                                               -4  [DEL]
      [DEL]      -2 [Other]                                                                                   -2  [DEL]
      [DEL]      -2 pollset_add_fd                                                                            -2  [DEL]
      [DEL]      -2 pollset_set_add_fd                                                                        -2  [DEL]
      [DEL]      -2 pollset_set_del_fd                                                                        -2  [DEL]
      [DEL]      -2 pollset_set_destroy                                                                       -2  [DEL]
      [DEL]      -2 pollset_set_add_pollset                                                                   -2  [DEL]
      [DEL]      -2 pollset_set_del_pollset                                                                   -2  [DEL]
      [DEL]      -2 pollset_set_add_pollset_set                                                               -2  [DEL]
  -8.1%    -256 src/core/lib/security/context/security_context.cc                                       -256  -8.1%
     -30.0%    -133 grpc_call_set_credentials                                                               -133 -30.0%
     -46.4%    -122 grpc_client_security_context_destroy                                                    -122 -46.4%
      [DEL]      -5 auth_context_pointer_arg_destroy                                                          -5  [DEL]
      -2.3%      -4 [Unmapped]                                                                                -4  -2.3%
 -21.6%    -256 src/core/lib/surface/byte_buffer_reader.cc                                              -256 -21.6%
     -25.8%    -128 grpc_byte_buffer_reader_readall                                                         -128 -25.8%
     -27.6%    -121 grpc_byte_buffer_reader_init                                                            -121 -27.6%
     -22.6%      -7 [Unmapped]                                                                                -7 -22.6%
  -8.2%    -240 src/core/lib/iomgr/executor.cc                                                          -240  -8.2%
      [DEL] -1.27Ki executor_push                                                                        -1.27Ki  [DEL]
      [DEL]    -567 grpc_executor_set_threading                                                             -567  [DEL]
      [DEL]    -166 run_closures(grpc_closure_list) [clone .isra.4]                                         -166  [DEL]
     -21.3%    -144 executor_thread                                                                         -144 -21.3%
      [DEL]     -21 grpc_executor_init                                                                       -21  [DEL]
      [DEL]     -10 executor_push_short                                                                      -10  [DEL]
      [DEL]      -7 grpc_executor_shutdown                                                                    -7  [DEL]
      [DEL]      -7 executor_push_long                                                                        -7  [DEL]
      -1.2%      -1 [Unmapped]                                                                                -1  -1.2%
 -13.4%    -240 src/core/lib/iomgr/resolve_address_posix.cc                                             -240 -13.4%
     -18.5%    -274 blocking_resolve_address_impl                                                           -274 -18.5%
      [DEL]    -165 resolve_address_impl                                                                    -165  [DEL]
      [DEL]     -90 do_request_thread                                                                        -90  [DEL]
  -9.7%    -240 src/core/lib/iomgr/timer_manager.cc                                                     -240  -9.7%
     -11.5%    -136 timer_thread                                                                            -136 -11.5%
     -46.7%    -105 grpc_timer_manager_tick                                                                 -105 -46.7%
  -9.7%    -224 src/core/lib/security/credentials/credentials.cc                                        -224  -9.7%
     -41.2%    -105 grpc_call_credentials_release                                                           -105 -41.2%
     -41.2%    -105 grpc_channel_credentials_release                                                        -105 -41.2%
     -41.2%    -105 grpc_server_credentials_release                                                         -105 -41.2%
      [DEL]     -99 grpc_channel_credentials_create_security_connector                                       -99  [DEL]
      [DEL]     -75 grpc_server_credentials_unref                                                            -75  [DEL]
      [DEL]     -69 grpc_server_credentials_create_security_connector                                        -69  [DEL]
      [DEL]     -51 grpc_call_credentials_unref                                                              -51  [DEL]
      [DEL]     -51 grpc_channel_credentials_unref                                                           -51  [DEL]
      [DEL]     -30 grpc_credentials_metadata_request_destroy                                                -30  [DEL]
      [DEL]     -30 grpc_call_credentials_get_request_metadata                                               -30  [DEL]
      [DEL]     -26 grpc_call_credentials_cancel_get_request_metadata                                        -26  [DEL]
      [DEL]      -5 credentials_pointer_arg_destroy                                                           -5  [DEL]
      [DEL]      -5 server_credentials_pointer_arg_destroy                                                    -5  [DEL]
 -14.1%    -201 src/core/lib/iomgr/iomgr.cc                                                             -201 -14.1%
      [DEL]    -836 grpc_iomgr_shutdown                                                                     -836  [DEL]
      [DEL]    -272 grpc_iomgr_init                                                                         -272  [DEL]
      [DEL]     -87 dump_objects(char const*) [clone .constprop.2]                                           -87  [DEL]
      [DEL]      -5 grpc_iomgr_start                                                                          -5  [DEL]
  -9.0%    -192 src/core/lib/compression/stream_compression_gzip.cc                                     -192  -9.0%
     -11.6%    -184 gzip_flate                                                                              -184 -11.6%
     -20.0%      -8 [Unmapped]                                                                                -8 -20.0%
  -4.2%    -181 src/core/lib/slice/slice_buffer.cc                                                      -181  -4.2%
     -51.4%    -107 grpc_slice_buffer_destroy                                                               -107 -51.4%
     -51.4%    -107 grpc_slice_buffer_reset_and_unref                                                       -107 -51.4%
      [DEL]     -88 grpc_slice_buffer_reset_and_unref_internal                                               -88  [DEL]
      [DEL]     -34 grpc_slice_buffer_destroy_internal                                                       -34  [DEL]
 -21.2%    -139 src/core/ext/transport/chttp2/client/insecure/channel_create_posix.cc                   -139 -21.2%
     -21.2%    -139 grpc_insecure_channel_create_from_fd                                                    -139 -21.2%
  -6.2%    -128 src/core/ext/filters/client_channel/channel_connectivity.cc                             -128  -6.2%
      [DEL]    -579 partly_done                                                                             -579  [DEL]
      [DEL]    -153 finished_completion                                                                     -153  [DEL]
     -29.3%    -115 grpc_channel_check_connectivity_state                                                   -115 -29.3%
     -15.6%    -112 grpc_channel_watch_connectivity_state                                                   -112 -15.6%
      [DEL]     -64 watcher_timer_init                                                                       -64  [DEL]
      [DEL]     -29 watch_complete                                                                           -29  [DEL]
      [DEL]     -26 timeout_complete                                                                         -26  [DEL]

 -+-+-+-+-+-+-+ MIXED                                                                                +-+-+-+-+-+-+-
  +1.7% +9.76Ki [None]                                                                               -6.18Ki  -0.1%
      [NEW]    +192 init_transport(grpc_exec_ctx*, grpc_chttp2_transport*, grpc_channel_args const*, grp    +192  [NEW]
      [NEW]     +60 CSWTCH.2                                                                                 +60  [NEW]
      [NEW]     +32 grpc_lb_policy_grpclb_build_lb_channel_args(grpc_exec_ctx*, grpc_slice_hash_table*,      +32  [NEW]
      [NEW]     +32 parse_lithdr_incidx_v(grpc_exec_ctx*, grpc_chttp2_hpack_parser*, unsigned char const     +32  [NEW]
      [NEW]     +32 parse_lithdr_notidx_v(grpc_exec_ctx*, grpc_chttp2_hpack_parser*, unsigned char const     +32  [NEW]
      [NEW]     +32 parse_lithdr_nvridx_v(grpc_exec_ctx*, grpc_chttp2_hpack_parser*, unsigned char const     +32  [NEW]
      [NEW]     +24 parse_lithdr_incidx_x(grpc_exec_ctx*, grpc_chttp2_hpack_parser*, unsigned char const     +24  [NEW]
      [NEW]     +24 parse_lithdr_notidx_x(grpc_exec_ctx*, grpc_chttp2_hpack_parser*, unsigned char const     +24  [NEW]
      [NEW]     +24 parse_lithdr_nvridx_x(grpc_exec_ctx*, grpc_chttp2_hpack_parser*, unsigned char const     +24  [NEW]
      [NEW]     +16 grpc_lb_subchannel_list_create(grpc_exec_ctx*, grpc_lb_policy*, grpc_core::TraceFlag     +16  [NEW]
      [NEW]     +16 parse_lithdr_incidx(grpc_exec_ctx*, grpc_chttp2_hpack_parser*, unsigned char const*,     +16  [NEW]
      [NEW]     +16 parse_lithdr_notidx(grpc_exec_ctx*, grpc_chttp2_hpack_parser*, unsigned char const*,     +16  [NEW]
      [NEW]     +16 parse_lithdr_nvridx(grpc_exec_ctx*, grpc_chttp2_hpack_parser*, unsigned char const*,     +16  [NEW]
      [NEW]     +16 dns_ares_on_resolved_locked(grpc_exec_ctx*, void*, grpc_error*)::args_to_remove            0  [ = ]
      [NEW]      +8 grpc_subchannel_create(grpc_exec_ctx*, grpc_connector*, grpc_subchannel_args const*)      +8  [NEW]
      [NEW]      +8 grpc_lb_policy_grpclb_create_lb_channel(grpc_exec_ctx*, char const*, grpc_client_cha      +8  [NEW]
      [NEW]      +8 glb_create(grpc_exec_ctx*, grpc_lb_policy_factory*, grpc_lb_policy_args*)::args_to_r      +8  [NEW]
      [NEW]      +8 parse_max_tbl_size_x(grpc_exec_ctx*, grpc_chttp2_hpack_parser*, unsigned char const*      +8  [NEW]
      [NEW]      +8 lb_policy_args_create(grpc_exec_ctx*, glb_lb_policy*)::keys_to_remove                     +8  [NEW]
      [NEW]      +8 parse_indexed_field_x(grpc_exec_ctx*, grpc_chttp2_hpack_parser*, unsigned char const      +8  [NEW]
      [DEL]    -192 init_transport(grpc_chttp2_transport*, grpc_channel_args const*, grpc_endpoint*, boo    -192  [DEL]
      [DEL]     -60 CSWTCH.3                                                                                 -60  [DEL]
      [DEL]     -32 grpc_lb_policy_grpclb_build_lb_channel_args(grpc_slice_hash_table*, grpc_fake_resolv     -32  [DEL]
      [DEL]     -32 parse_lithdr_incidx_v(grpc_chttp2_hpack_parser*, unsigned char const*, unsigned char     -32  [DEL]
      [DEL]     -32 parse_lithdr_notidx_v(grpc_chttp2_hpack_parser*, unsigned char const*, unsigned char     -32  [DEL]
      [DEL]     -32 parse_lithdr_nvridx_v(grpc_chttp2_hpack_parser*, unsigned char const*, unsigned char     -32  [DEL]
      [DEL]     -24 [Other]                                                                                  -24  [DEL]
      [DEL]     -24 vtable for ExecCtxNext                                                                   -24  [DEL]
      [DEL]     -24 vtable for ExecCtxPluck                                                                  -24  [DEL]
      [DEL]     -24 vtable for grpc_core::ExecCtx                                                            -24  [DEL]
      [DEL]     -24 parse_lithdr_incidx_x(grpc_chttp2_hpack_parser*, unsigned char const*, unsigned char     -24  [DEL]
      [DEL]     -24 parse_lithdr_notidx_x(grpc_chttp2_hpack_parser*, unsigned char const*, unsigned char     -24  [DEL]
      [DEL]     -24 parse_lithdr_nvridx_x(grpc_chttp2_hpack_parser*, unsigned char const*, unsigned char     -24  [DEL]
      [DEL]     -16 grpc_lb_subchannel_list_create(grpc_lb_policy*, grpc_core::TraceFlag*, grpc_lb_addre     -16  [DEL]
      [DEL]     -16 parse_lithdr_incidx(grpc_chttp2_hpack_parser*, unsigned char const*, unsigned char c     -16  [DEL]
      [DEL]     -16 parse_lithdr_notidx(grpc_chttp2_hpack_parser*, unsigned char const*, unsigned char c     -16  [DEL]
      [DEL]     -16 parse_lithdr_nvridx(grpc_chttp2_hpack_parser*, unsigned char const*, unsigned char c     -16  [DEL]
      [DEL]     -16 dns_ares_on_resolved_locked(void*, grpc_error*)::args_to_remove                            0  [ = ]
      [DEL]      -8 grpc_subchannel_create(grpc_connector*, grpc_subchannel_args const*)::keys_to_remove      -8  [DEL]
      [DEL]      -8 grpc_lb_policy_grpclb_create_lb_channel(char const*, grpc_client_channel_factory*, g      -8  [DEL]
      [DEL]      -8 glb_create(grpc_lb_policy_factory*, grpc_lb_policy_args*)::args_to_remove                 -8  [DEL]

  +0.8% +9.48Ki TOTAL                                                                                -6.46Ki  -0.1%


****************************************************************

libgrpc++.so

     VM SIZE                                                                                            FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +2.6%     +16 src/cpp/common/channel_filter.cc                                                         +16  +2.6%
      [NEW]    +270 grpc::MetadataBatch::AddMetadata                                                        +270  [NEW]
      [NEW]     +97 grpc::internal::(anonymous namespace)::MaybeAddFilter                                    +97  [NEW]
      [NEW]     +14 grpc::ChannelData::StartTransportOp                                                      +14  [NEW]
      [NEW]     +14 grpc::ChannelData::GetInfo                                                               +14  [NEW]
      [NEW]     +14 grpc::CallData::SetPollsetOrPollsetSet                                                   +14  [NEW]
      [NEW]     +14 grpc::CallData::StartTransportStreamOpBatch                                              +14  [NEW]
      [NEW]      +3 grpc::ChannelData::Init                                                                   +3  [NEW]
      [NEW]      +3 grpc::CallData::Init                                                                      +3  [NEW]
      [NEW]      +2 grpc::ChannelData::Destroy                                                                +2  [NEW]
      [NEW]      +2 grpc::CallData::Destroy                                                                   +2  [NEW]

 -------------- SHRINKING                                                                            --------------
  -0.2%    -501 [None]                                                                               -3.07Ki  -0.1%
      -0.2%    -416 [Unmapped]                                                                           -3.01Ki  -0.1%
     -18.5%     -24 [None]                                                                                     0  [ = ]
      [DEL]     -24 vtable for grpc_core::ExecCtx                                                            -24  [DEL]
      [DEL]     -21 typeinfo name for grpc_core::ExecCtx                                                     -21  [DEL]
      [DEL]     -16 typeinfo for grpc_core::ExecCtx                                                          -16  [DEL]
  -4.1%    -227 src/cpp/common/channel_arguments.cc                                                     -227  -4.1%
      [DEL]    -194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    -194  [DEL]
     -14.6%    -118 grpc::ChannelArguments::SetSocketMutator                                                -118 -14.6%
     -31.5%    -112 grpc::ChannelArguments::~ChannelArguments                                               -112 -31.5%
      [DEL]      -3 grpc_core::ExecCtx::CheckReadyToFinish                                                    -3  [DEL]
      [DEL]      -2 grpc::ChannelArguments::PointerVtableMembers::Destroy                                     -2  [DEL]

  -0.2%    -712 TOTAL                                                                                -3.27Ki  -0.1%



@yashykt
Copy link
Copy Markdown
Member Author

yashykt commented Dec 6, 2017

@jtattermusch going to patch this into google and get that to build before getting this in OSS to avoid delaying the import

@grpc-testing
Copy link
Copy Markdown

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

[microbenchmarks] Performance differences noted:
Benchmark                      cpu_time    real_time
-----------------------------  ----------  -----------
BM_ErrorCreateAndSetIntAndStr  +7%         +7%
BM_ErrorCreateAndSetStatus     +7%         +7%
BM_ErrorCreateAndSetStrLoop    +102%       +102%
BM_ErrorCreateFromStatic       +9%         +9%

@nicolasnoble nicolasnoble deleted the revert-13058-execctx branch January 19, 2018 23:01
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants