Carry on from #13468, simplify bazel consumption of grpc by apolcyn · Pull Request #13561 · grpc/grpc

apolcyn · 2017-11-30T01:15:50Z

This PR carries on from #13468, and the most recent (3rd) commit here follows the suggestion in a comment on that PR.

Used the greeter_server (with everything protobuf-related removed) to test use-of-grpc-in-bazel from a local 3rd party project using a BUILD rule that looks like:

cc_binary(
    name = "greeter_server",
    srcs = ["cpp/helloworld/greeter_server.cc"],
    deps = ["@com_github_grpc_grpc//:grpc++"],
)

and a WORKSPACE file of:

local_repository(
  name = "com_github_grpc_grpc",
  path = "/grpc",

)

load("@com_github_grpc_grpc//bazel:grpc_deps.bzl", "grpc_deps")
grpc_deps()

grpc-testing · 2017-11-30T01:18:41Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-30T01:29:36Z

[trickle] No significant performance differences

grpc-testing · 2017-11-30T02:02:50Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-30T02:09:31Z

[microbenchmarks] No significant performance differences

grpc-testing · 2017-11-30T02:14:09Z

[trickle] No significant performance differences

grpc-testing · 2017-11-30T02:55:04Z

[microbenchmarks] No significant performance differences

grpc-testing · 2017-11-30T03:53:55Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-30T04:06:37Z

[trickle] No significant performance differences

grpc-testing · 2017-11-30T04:45:51Z

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_InProcessCHTTP2__1.opt.old: 1


[microbenchmarks] No significant performance differences

apolcyn · 2017-11-30T20:40:59Z

I think this is ready for review now

grpc-testing · 2017-12-05T18:41:25Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-12-05T18:52:00Z

[trickle] No significant performance differences

grpc-testing · 2017-12-05T19:33:10Z

[microbenchmarks] No significant performance differences

grpc-testing · 2017-12-05T21:47:19Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-12-05T21:55:23Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-12-05T22:00:47Z

[trickle] No significant performance differences

grpc-testing · 2017-12-05T22:08:05Z

[trickle] No significant performance differences

grpc-testing · 2017-12-05T22:24:08Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-12-05T22:35:44Z

[trickle] No significant performance differences

grpc-testing · 2017-12-08T00:28:21Z

****************************************************************

libgrpc.so

     VM SIZE                                                                                            FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +2.7%     +80 src/core/ext/filters/client_channel/lb_policy/grpclb/load_balancer_api.cc                +80  +2.7%
      +8.2%     +40 grpc_grpclb_response_parse_serverlist                                                    +40  +8.2%
       +11%     +24 grpc_grpclb_serverlist_copy                                                              +24   +11%
       +18%     +21 grpc_grpclb_serverlist_equals                                                            +21   +18%

 -------------- SHRINKING                                                                            --------------
  -1.8%    -272 src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc                          -272  -1.8%
      [DEL] -1.67Ki rr_handover_locked(grpc_exec_ctx*, glb_lb_policy*) [clone .part.10]                  -1.67Ki  [DEL]
      [DEL] -1.28Ki query_for_backends_locked(grpc_exec_ctx*, glb_lb_policy*) [clone .part.8]            -1.28Ki  [DEL]
      [DEL]    -834 build_lb_channel_args(grpc_exec_ctx*, grpc_lb_addresses const*, grpc_fake_resolver_r    -834  [DEL]
      [DEL]    -235 glb_ping_one_locked                                                                     -235  [DEL]
     -17.5%    -112 glb_shutdown_locked                                                                     -112 -17.5%
  -1.0%    -144 src/core/ext/filters/client_channel/client_channel.cc                                   -144  -1.0%
     -17.8%    -144 start_transport_op_locked                                                               -144 -17.8%
      -1.8%      -3 cc_start_transport_op                                                                     -3  -1.8%
  -2.2%    -112 src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc                  -112  -2.2%
      [DEL]    -341 pf_ping_one_locked                                                                      -341  [DEL]
  -1.9%    -112 src/core/ext/filters/client_channel/lb_policy/round_robin/round_robin.cc                -112  -1.9%
      [DEL]    -415 rr_ping_one_locked                                                                      -415  [DEL]
  -7.5%    -112 src/core/lib/surface/lame_client.cc                                                     -112  -7.5%
     -27.8%    -115 grpc_core::(anonymous namespace)::lame_start_transport_op                               -115 -27.8%
  -3.0%     -64 src/core/lib/transport/transport_op_string.cc                                            -64  -3.0%
      -8.4%     -75 grpc_transport_op_string                                                                 -75  -8.4%
  -0.0%     -16 src/core/ext/transport/chttp2/transport/chttp2_transport.cc                              -16  -0.0%
      -6.1%     -16 perform_transport_op_locked                                                              -16  -6.1%
      -3.2%      -3 perform_transport_op                                                                      -3  -3.2%

 -+-+-+-+-+-+-+ MIXED                                                                                +-+-+-+-+-+-+-
  +0.0%      +8 [None]                                                                               -8.95Ki  -0.2%
      +2.7%     +32 [None]                                                                                     0  [ = ]
       +50%     +14 grpc_lb_v1_ServerList_fields                                                             +14   +50%

  -0.1%    -744 TOTAL                                                                                -9.68Ki  -0.2%


****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%

grpc-testing · 2017-12-08T00:31:54Z

****************************************************************

libgrpc.so

     VM SIZE                                                                                            FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +2.7%     +80 src/core/ext/filters/client_channel/lb_policy/grpclb/load_balancer_api.cc                +80  +2.7%
      +8.2%     +40 grpc_grpclb_response_parse_serverlist                                                    +40  +8.2%
       +11%     +24 grpc_grpclb_serverlist_copy                                                              +24   +11%
       +18%     +21 grpc_grpclb_serverlist_equals                                                            +21   +18%

 -------------- SHRINKING                                                                            --------------
  -1.8%    -272 src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc                          -272  -1.8%
      [DEL] -1.67Ki rr_handover_locked(grpc_exec_ctx*, glb_lb_policy*) [clone .part.10]                  -1.67Ki  [DEL]
      [DEL] -1.28Ki query_for_backends_locked(grpc_exec_ctx*, glb_lb_policy*) [clone .part.8]            -1.28Ki  [DEL]
      [DEL]    -834 build_lb_channel_args(grpc_exec_ctx*, grpc_lb_addresses const*, grpc_fake_resolver_r    -834  [DEL]
      [DEL]    -235 glb_ping_one_locked                                                                     -235  [DEL]
     -17.5%    -112 glb_shutdown_locked                                                                     -112 -17.5%
  -1.0%    -144 src/core/ext/filters/client_channel/client_channel.cc                                   -144  -1.0%
     -17.8%    -144 start_transport_op_locked                                                               -144 -17.8%
      -1.8%      -3 cc_start_transport_op                                                                     -3  -1.8%
  -2.2%    -112 src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc                  -112  -2.2%
      [DEL]    -341 pf_ping_one_locked                                                                      -341  [DEL]
  -1.9%    -112 src/core/ext/filters/client_channel/lb_policy/round_robin/round_robin.cc                -112  -1.9%
      [DEL]    -415 rr_ping_one_locked                                                                      -415  [DEL]
  -7.5%    -112 src/core/lib/surface/lame_client.cc                                                     -112  -7.5%
     -27.8%    -115 grpc_core::(anonymous namespace)::lame_start_transport_op                               -115 -27.8%
  -3.0%     -64 src/core/lib/transport/transport_op_string.cc                                            -64  -3.0%
      -8.4%     -75 grpc_transport_op_string                                                                 -75  -8.4%
  -0.0%     -16 src/core/ext/transport/chttp2/transport/chttp2_transport.cc                              -16  -0.0%
      -6.1%     -16 perform_transport_op_locked                                                              -16  -6.1%
      -3.2%      -3 perform_transport_op                                                                      -3  -3.2%

 -+-+-+-+-+-+-+ MIXED                                                                                +-+-+-+-+-+-+-
  +0.0%      +8 [None]                                                                               -8.95Ki  -0.2%
      +2.7%     +32 [None]                                                                                     0  [ = ]
       +50%     +14 grpc_lb_v1_ServerList_fields                                                             +14   +50%

  -0.1%    -744 TOTAL                                                                                -9.68Ki  -0.2%


****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%

grpc-testing · 2017-12-08T00:35:59Z

****************************************************************

libgrpc.so

     VM SIZE                                                                                            FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +2.7%     +80 src/core/ext/filters/client_channel/lb_policy/grpclb/load_balancer_api.cc                +80  +2.7%
      +8.2%     +40 grpc_grpclb_response_parse_serverlist                                                    +40  +8.2%
       +11%     +24 grpc_grpclb_serverlist_copy                                                              +24   +11%
       +18%     +21 grpc_grpclb_serverlist_equals                                                            +21   +18%

 -------------- SHRINKING                                                                            --------------
  -1.8%    -272 src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc                          -272  -1.8%
      [DEL] -1.67Ki rr_handover_locked(grpc_exec_ctx*, glb_lb_policy*) [clone .part.10]                  -1.67Ki  [DEL]
      [DEL] -1.28Ki query_for_backends_locked(grpc_exec_ctx*, glb_lb_policy*) [clone .part.8]            -1.28Ki  [DEL]
      [DEL]    -834 build_lb_channel_args(grpc_exec_ctx*, grpc_lb_addresses const*, grpc_fake_resolver_r    -834  [DEL]
      [DEL]    -235 glb_ping_one_locked                                                                     -235  [DEL]
     -17.5%    -112 glb_shutdown_locked                                                                     -112 -17.5%
  -1.0%    -144 src/core/ext/filters/client_channel/client_channel.cc                                   -144  -1.0%
     -17.8%    -144 start_transport_op_locked                                                               -144 -17.8%
      -1.8%      -3 cc_start_transport_op                                                                     -3  -1.8%
  -2.2%    -112 src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc                  -112  -2.2%
      [DEL]    -341 pf_ping_one_locked                                                                      -341  [DEL]
  -1.9%    -112 src/core/ext/filters/client_channel/lb_policy/round_robin/round_robin.cc                -112  -1.9%
      [DEL]    -415 rr_ping_one_locked                                                                      -415  [DEL]
  -7.5%    -112 src/core/lib/surface/lame_client.cc                                                     -112  -7.5%
     -27.8%    -115 grpc_core::(anonymous namespace)::lame_start_transport_op                               -115 -27.8%
  -3.0%     -64 src/core/lib/transport/transport_op_string.cc                                            -64  -3.0%
      -8.4%     -75 grpc_transport_op_string                                                                 -75  -8.4%
  -0.0%     -16 src/core/ext/transport/chttp2/transport/chttp2_transport.cc                              -16  -0.0%
      -6.1%     -16 perform_transport_op_locked                                                              -16  -6.1%
      -3.2%      -3 perform_transport_op                                                                      -3  -3.2%

 -+-+-+-+-+-+-+ MIXED                                                                                +-+-+-+-+-+-+-
  +0.0%      +8 [None]                                                                               -8.95Ki  -0.2%
      +2.7%     +32 [None]                                                                                     0  [ = ]
       +50%     +14 grpc_lb_v1_ServerList_fields                                                             +14   +50%

  -0.1%    -744 TOTAL                                                                                -9.68Ki  -0.2%


****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%

apolcyn · 2017-12-08T00:36:06Z

I think this is good for a look again, changed the sanity check to use exec rather than parsing

PTAL

grpc-testing · 2017-12-08T00:39:44Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-12-08T00:39:58Z

[trickle] No significant performance differences

grpc-testing · 2017-12-08T00:44:25Z

[trickle] No significant performance differences

grpc-testing · 2017-12-08T00:47:31Z

[trickle] No significant performance differences

grpc-testing · 2017-12-08T00:50:39Z

[trickle] No significant performance differences

grpc-testing · 2017-12-08T01:20:03Z

[microbenchmarks] No significant performance differences

grpc-testing · 2017-12-08T01:24:54Z

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPong_InProcessCHTTP2_NoOpMutator_NoOpMutator__4096_2.opt.new: 1


[microbenchmarks] No significant performance differences

grpc-testing · 2017-12-08T01:28:39Z

[microbenchmarks] No significant performance differences

grpc-testing · 2017-12-08T01:31:08Z

[microbenchmarks] No significant performance differences

grpc-testing · 2017-12-14T19:25:55Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-12-14T19:35:35Z

[trickle] No significant performance differences

grpc-testing · 2017-12-14T20:17:28Z

[microbenchmarks] No significant performance differences

apolcyn · 2017-12-15T01:20:08Z

squashing down my commits to 1

…sued by other projects, and simplifies cares build.

…s dependency check. Otherwise include "third_party/nanopb/pb.h" will find local ph.h rather than the one in "//external:nanopb".

grpc-testing · 2017-12-15T02:15:38Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-12-15T02:28:12Z

[trickle] No significant performance differences

grpc-testing · 2017-12-15T03:07:09Z

[microbenchmarks] No significant performance differences

apolcyn · 2017-12-15T04:41:20Z

test failures:

asan c++ thread_stress_test --gtest_filter=AsyncClientEnd2endTest.ThreadStress newly flaky (TIMEOUT) #13148
basic tests c++ linux: Flake: bins/dbg/h2_ssl_cert_test --gtest_filter=H2SslCertTest.SimpleRequestBody #13477

apolcyn added the infra/buildgen label Nov 30, 2017

apolcyn requested review from ctiller, dgquintas and nicolasnoble as code owners November 30, 2017 01:15

apolcyn added the disposition/DO NOT MERGE label Nov 30, 2017

apolcyn changed the title ~~Carry on from #13468, simplify bazel consumption of grpc~~ WIP: Carry on from #13468, simplify bazel consumption of grpc Nov 30, 2017

apolcyn requested a review from muxi November 30, 2017 20:40

apolcyn removed the disposition/DO NOT MERGE label Nov 30, 2017

apolcyn changed the title ~~WIP: Carry on from #13468, simplify bazel consumption of grpc~~ Carry on from #13468, simplify bazel consumption of grpc Nov 30, 2017

ctiller approved these changes Dec 4, 2017

View reviewed changes

apolcyn force-pushed the revise_bazel_api branch from 8ce481a to 37e40f1 Compare December 5, 2017 21:51

apolcyn force-pushed the revise_bazel_api branch from d0bd2f0 to 90fac4f Compare December 8, 2017 00:27

apolcyn force-pushed the revise_bazel_api branch from 90fac4f to 0f05411 Compare December 8, 2017 00:31

Ning Ren and others added 3 commits December 14, 2017 17:37

Packs contents of WORKSPACE into a bzl function, so that it can be re…

174e02a

…sued by other projects, and simplifies cares build.

Depends third_party/nanopb via workspace relative-path to pass bazel'…

00a7d47

…s dependency check. Otherwise include "third_party/nanopb/pb.h" will find local ph.h rather than the one in "//external:nanopb".

Move more special cases in bazel build to the .bzl files

54a7040

apolcyn force-pushed the revise_bazel_api branch from 0ea493f to 54a7040 Compare December 15, 2017 02:12

apolcyn merged commit dd1dbca into grpc:master Dec 15, 2017

apolcyn mentioned this pull request Jan 9, 2018

Using gRPC from a Bazel project is too complex #13502

Closed

lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019

Conversation

apolcyn commented Nov 30, 2017

Uh oh!

grpc-testing commented Nov 30, 2017

Uh oh!

grpc-testing commented Nov 30, 2017

Uh oh!

grpc-testing commented Nov 30, 2017

Uh oh!

grpc-testing commented Nov 30, 2017

Uh oh!

grpc-testing commented Nov 30, 2017

Uh oh!

grpc-testing commented Nov 30, 2017

Uh oh!

grpc-testing commented Nov 30, 2017

Uh oh!

grpc-testing commented Nov 30, 2017

Uh oh!

grpc-testing commented Nov 30, 2017

Uh oh!

apolcyn commented Nov 30, 2017

Uh oh!

grpc-testing commented Dec 5, 2017

Uh oh!

grpc-testing commented Dec 5, 2017

Uh oh!

grpc-testing commented Dec 5, 2017

Uh oh!

grpc-testing commented Dec 5, 2017

Uh oh!

grpc-testing commented Dec 5, 2017

Uh oh!

grpc-testing commented Dec 5, 2017

Uh oh!

grpc-testing commented Dec 5, 2017

Uh oh!

grpc-testing commented Dec 5, 2017

Uh oh!

grpc-testing commented Dec 5, 2017

Uh oh!

grpc-testing commented Dec 8, 2017

Uh oh!

grpc-testing commented Dec 8, 2017

Uh oh!

grpc-testing commented Dec 8, 2017

Uh oh!

apolcyn commented Dec 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grpc-testing commented Dec 8, 2017

Uh oh!

grpc-testing commented Dec 8, 2017

Uh oh!

grpc-testing commented Dec 8, 2017

Uh oh!

grpc-testing commented Dec 8, 2017

Uh oh!

grpc-testing commented Dec 8, 2017

Uh oh!

grpc-testing commented Dec 8, 2017

Uh oh!

grpc-testing commented Dec 8, 2017

Uh oh!

grpc-testing commented Dec 8, 2017

Uh oh!

grpc-testing commented Dec 8, 2017

Uh oh!

grpc-testing commented Dec 14, 2017

Uh oh!

grpc-testing commented Dec 14, 2017

Uh oh!

grpc-testing commented Dec 14, 2017

Uh oh!

apolcyn commented Dec 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grpc-testing commented Dec 15, 2017

Uh oh!

grpc-testing commented Dec 15, 2017

apolcyn commented Dec 8, 2017 •

edited

Loading

apolcyn commented Dec 15, 2017 •

edited

Loading