Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

• User @renning22 isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
The Linux Foundation CLA GitHub bot

I am going to merge #13060 first - you'll most likely want to revisit your PR after that.

Ack, thanks @nicolasnoble .

Also, I'm sorry, but I won't be able to accept your PR if you don't accept the linux foundation CLA. Please visit https://identity.linuxfoundation.org/projects/cncf for this.

Thanks @nicolasnoble ,
I have signed linux foundation CLA and the PR is ready to review.

You'll want to update this file so the test pass again:

https://github.com/grpc/grpc/blob/master/tools/run_tests/sanity/check_bazel_workspace.py

You might consider adopting the pattern used by https://github.com/bazelbuild/rules_go to allow users to optionally overwrite one or more of the dependencies supplied by your Skylark rules. For example,

if "com_github_bazelbuild_buildtools" not in native.existing_rules():
    native.http_archive(
        name = "com_github_bazelbuild_buildtools",
        url = "https://codeload.github.com/bazelbuild/buildtools/zip/799e530642bac55de7e76728fa0c3161484899f6",
        strip_prefix = "buildtools-799e530642bac55de7e76728fa0c3161484899f6",
        type = "zip",
    )

The conditional works such that it will only install the version of Buildtools, supplied below if the user is not explicitly binding a rule of the same name somewhere else. See https://github.com/bazelbuild/rules_go/blob/master/go/private/repositories.bzl for more examples. A little more discussion can be found at https://groups.google.com/forum/#!topic/bazel-discuss/EBeFucaAg3A.

I've fixed "check_bazel_workspace.py" test. It still not passing on my machine because "git submodule" for protobuf is still 80a37e0782d2d702d52234b62dd4b9ec74fd2c95, while the expectation has been updated in 28661ea. I guess it should also fail "check_submodules.sh".

@jwpowell055 also adopted your suggestion, thanks!