Merged
Conversation
apolcyn
reviewed
Nov 16, 2017
| var callback = cq.CompletionRegistry.Extract(tag); | ||
| // Use cached delegates to avoid unnecessary allocations | ||
| queuedContinuationCounter.Increment(); | ||
| if (!inlineHandlers) |
Contributor
There was a problem hiding this comment.
Realizing now, are we not setting inlineHandlers to true anywhere, including benchmarks?
Contributor
Author
There was a problem hiding this comment.
Yes, it's not being used in benchmarks because I thought it's also important to tests the performance with the "default" settings (right now the C# performance actually isn't much different with inlineHandlers==true because there are some other bottlenecks - i'm investigating).
apolcyn
approved these changes
Nov 17, 2017
Contributor
apolcyn
left a comment
apolcyn
left a comment
There was a problem hiding this comment.
had one question, but lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-- honor the "grpc.optimization_target" channel argument when set by scenario_config.py
-- balance out
queuedContinuationCounterwhen inlineHandlers==true (values were only getting decremented, not incremented).