Restart LB call after client load report completion, if needed.#13417
Merged
markdroth merged 1 commit intogrpc:masterfrom Nov 16, 2017
Merged
Restart LB call after client load report completion, if needed.#13417markdroth merged 1 commit intogrpc:masterfrom
markdroth merged 1 commit intogrpc:masterfrom
Conversation
|
|
|
dgquintas
approved these changes
Nov 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13350.
The problem here was that if the client load report completion callback was in flight when we received status, then we were not cleaning up. We were already handling this properly if we received status when the client load report timer had not yet fired (see
send_client_load_report_locked()), but we were not handling the case where sending the load report itself was actually in flight. This PR makes the logic inclient_load_report_done_locked()match that ofsend_client_load_report_locked().Note that this is more than a simple memory leak; it could actually cause a client to fail to restart the LB call, thus continuing to use an increasingly stale serverlist.