Fix manual docker command output for Python. by adelez · Pull Request #13411 · grpc/grpc

adelez · 2017-11-15T23:13:08Z

Need to escape " in the Python client command when saving it to the manual log.
This also fixes #13230.

grpc-testing · 2017-11-15T23:16:12Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

nathanielmanistaatgoogle

Looks mostly good; thanks for the fix!

nathanielmanistaatgoogle · 2017-11-15T23:20:28Z

tools/interop_matrix/client_matrix.py

Any desire to add a v1.7.x tag to this list?

It'll be in #13398.

nathanielmanistaatgoogle · 2017-11-15T23:21:07Z

tools/interop_matrix/client_matrix.py

Is #13230 still an active issue? (@kpayson64?)

nathanielmanistaatgoogle · 2017-11-15T23:21:59Z

tools/interop_matrix/testcases/python__master

@@ -0,0 +1,20 @@
+#!/bin/bash
+echo "Testing ${docker_image:=grpc_interop_python:797ca293-94e8-48d4-92e9-a4d52fcfcca9}"


It's surprising to me that fixing this problem involves adding this whole large file to the codebase - was this an inadvertent addition or does this need to be here?

This is the test commands file that's needed for every language by the framework. Previously I was just testing locally.

Well... okay.

This is the current design. Here's the background: we debated on whether to create separate file for test cases for bake them into the images. Folks voted for the first, hence the need of these files checked in. But as I took over this project and started expansion, I felt the 2nd option probably works better. But it'll require a major architectural change.

grpc-testing · 2017-11-15T23:23:41Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-15T23:27:49Z

[trickle] No significant performance differences

grpc-testing · 2017-11-15T23:37:13Z

[trickle] No significant performance differences

grpc-testing · 2017-11-16T00:07:44Z

[microbenchmarks] No significant performance differences

grpc-testing · 2017-11-16T00:16:37Z

[microbenchmarks] No significant performance differences

grpc-testing · 2017-11-16T00:21:07Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

nathanielmanistaatgoogle

🎉

nathanielmanistaatgoogle · 2017-11-16T00:28:22Z

tools/interop_matrix/testcases/python__master

@@ -0,0 +1,20 @@
+#!/bin/bash
+echo "Testing ${docker_image:=grpc_interop_python:797ca293-94e8-48d4-92e9-a4d52fcfcca9}"


Well... okay.

adelez · 2017-11-16T00:31:11Z

That echo should probably be removed. I'll do a cleanup in a separate PR as it's not Python specific.

grpc-testing · 2017-11-16T00:33:11Z

[trickle] No significant performance differences

grpc-testing · 2017-11-16T01:13:05Z

[microbenchmarks] No significant performance differences

adelez · 2017-11-16T18:38:38Z

Asan C++ #13122
Basic Tests MacOS [dbg] #13381, #13085
Basic Tests Multi-language Linux #13085
Basic Tests Windows [dbg] #12595

adelez assigned nathanielmanistaatgoogle Nov 15, 2017

Fix manual docker command output for Python.

a00f972

adelez force-pushed the fix_python branch from 90de8db to a00f972 Compare November 15, 2017 23:20

nathanielmanistaatgoogle suggested changes Nov 15, 2017

View reviewed changes

nathanielmanistaatgoogle added area/test kind/bug lang/Python priority/P1 labels Nov 15, 2017

adelez mentioned this pull request Nov 15, 2017

Adding v1.7.x for some languages #13398

Merged

adelez added the kokoro:force-run label Nov 16, 2017

kokoro-team removed the kokoro:force-run label Nov 16, 2017

nathanielmanistaatgoogle approved these changes Nov 16, 2017

View reviewed changes

adelez merged commit 82c8f94 into grpc:master Nov 16, 2017

adelez deleted the fix_python branch November 16, 2017 19:52

lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019

		@@ -0,0 +1,20 @@
		#!/bin/bash
		echo "Testing ${docker_image:=grpc_interop_python:797ca293-94e8-48d4-92e9-a4d52fcfcca9}"

Conversation

adelez commented Nov 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grpc-testing commented Nov 15, 2017

Uh oh!

nathanielmanistaatgoogle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grpc-testing commented Nov 15, 2017

Uh oh!

grpc-testing commented Nov 15, 2017

Uh oh!

grpc-testing commented Nov 15, 2017

Uh oh!

grpc-testing commented Nov 16, 2017

Uh oh!

grpc-testing commented Nov 16, 2017

Uh oh!

grpc-testing commented Nov 16, 2017

Uh oh!

nathanielmanistaatgoogle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adelez commented Nov 16, 2017

Uh oh!

grpc-testing commented Nov 16, 2017

Uh oh!

grpc-testing commented Nov 16, 2017

Uh oh!

adelez commented Nov 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adelez commented Nov 15, 2017 •

edited

Loading