Merged
Conversation
ncteisen
force-pushed
the
inline-closure
branch
from
2d2901f to
1822297
Compare
|
1 similar comment
|
|
1 similar comment
|
|
|
|
|
|
ncteisen
force-pushed
the
inline-closure
branch
from
84c92d9 to
b945cc4
Compare
|
|
|
|
|
|
|
|
|
|
|
Contributor
Author
|
Switching reviewers because @ctiller is gone. This PR just inlines Closure because all of these functions were showing up as taking tons of cycles using internal, global profiling tools |
|
vjpai
reviewed
Nov 15, 2017
src/core/lib/iomgr/closure.h
Outdated
| grpc_closure_init(closure, cb, cb_arg, scheduler) | ||
| #endif | ||
|
|
||
| namespace { |
Contributor
There was a problem hiding this comment.
No anonymous namespaces inside header files . Just give it a name.
vjpai
reviewed
Nov 15, 2017
| } wrapped_closure; | ||
|
|
||
| static void closure_wrapper(grpc_exec_ctx* exec_ctx, void* arg, | ||
| grpc_error* error) { |
Contributor
There was a problem hiding this comment.
No static methods inside header files and, fwiw, why static and anonymous? That seems like overkill
|
|
vjpai
approved these changes
Nov 16, 2017
|
|
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.