log GRPC_POLL_STRATEGY when fail to find polling engine by yang-g · Pull Request #13281 · grpc/grpc

yang-g · 2017-11-06T22:37:32Z

No description provided.

grpc-testing · 2017-11-06T22:40:16Z

****************************************************************

libgrpc.so

     VM SIZE                                      FILE SIZE
 ++++++++++++++ GROWING                        ++++++++++++++
  +1.2%     +16 src/core/lib/iomgr/ev_posix.cc     +16  +1.2%
      +5.7%     +11 [Unmapped]                         +11  +5.7%
      +0.9%      +5 grpc_event_engine_init              +5  +0.9%

 -+-+-+-+-+-+-+ MIXED                          +-+-+-+-+-+-+-
  +0.0%     +48 [None]                              -8  -0.0%

  +0.0%     +64 TOTAL                               +8  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

sreecha

Thanks for doing this. Could you also add (or make sure enough log statements exist) in grpc_init_XXX functions in each polling engine to see why they are being skipped over?

grpc-testing · 2017-11-06T22:51:22Z

[trickle] No significant performance differences

also log reason to skip a polling engine

grpc-testing · 2017-11-06T23:16:19Z

****************************************************************

libgrpc.so

     VM SIZE                                      FILE SIZE
 ++++++++++++++ GROWING                        ++++++++++++++
  +1.2%     +16 src/core/lib/iomgr/ev_posix.cc     +16  +1.2%
      +5.7%     +11 [Unmapped]                         +11  +5.7%
      +0.9%      +5 grpc_event_engine_init              +5  +0.9%

 -+-+-+-+-+-+-+ MIXED                          +-+-+-+-+-+-+-
  +0.0%     +48 [None]                              -8  -0.0%

  +0.0%     +64 TOTAL                               +8  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-06T23:26:17Z

[trickle] No significant performance differences

grpc-testing · 2017-11-07T00:20:39Z

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__8_2_0.opt.old: 2
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__4096_2_0.opt.old: 3
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__0_2_0.opt.old: 2
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__32768_2_0.opt.old: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__64_2_0.opt.old: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__512_2_0.counters.new: 2
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__512_2_0.counters.new: 4
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__1_2_0.opt.new: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__32768_2_0.counters.new: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__512_2_0.opt.old: 3
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__1_2_0.counters.new: 2
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__64_2_0.counters.old: 4
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__4096_2_0.opt.old: 2
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__4096_2_0.counters.old: 2
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__8_2_0.counters.old: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__1_2_0.opt.old: 4
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__4096_2_0.counters.new: 4
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__8_2_0.opt.new: 3
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__64_2_0.counters.new: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__512_2_0.opt.old: 3
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__1_2_0.opt.new: 5
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__0_2_0.counters.old: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__64_2_0.opt.new: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__8_2_0.opt.old: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__4096_2_0.counters.old: 3
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__0_2_0.counters.new: 2
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__512_2_0.opt.new: 3
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__0_2_0.opt.new: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__8_2_0.counters.new: 4
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__64_2_0.opt.new: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__512_2_0.counters.old: 2
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__512_2_0.opt.new: 3
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__8_2_0.counters.new: 3
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__1_2_0.counters.old: 2
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__4096_2_0.counters.new: 3
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__0_2_0.counters.new: 2
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__64_2_0.counters.old: 3
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__1_2_0.counters.new: 3
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__1_2_0.counters.old: 2
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__64_2_0.opt.old: 2
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__64_2_0.counters.new: 3
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__4096_2_0.opt.new: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__2097152_1_0.opt.old: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__8_2_0.opt.new: 4
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__512_2_0.counters.old: 5


[microbenchmarks] Performance differences noted:
Benchmark                                                                                   cpu_time    real_time
------------------------------------------------------------------------------------------  ----------  -----------
BM_PollAddFd                                                                                +8%         +8%
BM_PumpStreamClientToServer<InProcess>/262144                                               +8%         +8%
BM_PumpStreamClientToServer<InProcess>/32768                                                +10%        +10%
BM_PumpStreamClientToServer<InProcessCHTTP2>/32768                                          +4%         +4%
BM_PumpStreamServerToClient<InProcess>/262144                                               +10%        +10%
BM_PumpStreamServerToClient<InProcess>/32768                                                +10%        +10%
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/1                          +5%         +5%
BM_StreamingPingPong<InProcessCHTTP2, NoOpMutator, NoOpMutator>/262144/1                    +4%         +4%
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/1                       +9%         +9%
BM_StreamingPingPong<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/262144/2                 +4%         +4%
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/262144                        +9%         +9%
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/32768                         +8%         +8%
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/262144                     +6%         +6%
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/32768                      +8%         +8%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/1/0       +7%         +7%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/1/1       +7%         +7%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/2/0       +8%         +8%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/32768/2/1        +5%         +5%
BM_StreamingPingPongWithCoalescingApi<InProcessCHTTP2, NoOpMutator, NoOpMutator>/32768/2/1  +4%         +4%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/262144/1/0    +6%         +6%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/262144/1/1    +8%         +8%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/262144/2/0    +5%         +5%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/262144/2/1    +4%         +4%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/32768/1/0     +5%         +5%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/32768/2/1     +8%         +8%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/262144                              -5%         -5%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/0                              -7%         -7%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/32768/32768                           -5%         -5%
BM_UnaryPingPong<InProcessCHTTP2, NoOpMutator, NoOpMutator>/0/262144                        -5%         -5%
BM_UnaryPingPong<InProcessCHTTP2, NoOpMutator, NoOpMutator>/262144/262144                   -5%         -5%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/262144                           -8%         -8%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/32768                            -4%         -4%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/0                           -8%         -8%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/262144                      -5%         -5%
BM_UnaryPingPong<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/262144/0                     -6%         -6%

grpc-testing · 2017-11-07T19:38:40Z

****************************************************************

libgrpc.so

     VM SIZE                                               FILE SIZE
 ++++++++++++++ GROWING                                 ++++++++++++++
  +0.1%    +433 [None]                                     +321  +0.0%
  +2.1%    +165 src/core/lib/iomgr/ev_epollsig_linux.cc    +165  +2.1%
       +59%    +165 grpc_init_epollsig_linux                   +165   +59%
  +0.6%     +66 src/core/lib/iomgr/ev_epollex_linux.cc      +66  +0.6%
       +50%     +66 grpc_init_epollex_linux                     +66   +50%
  +0.5%     +48 src/core/lib/iomgr/ev_epoll1_linux.cc       +48  +0.5%
      +8.2%     +48 grpc_init_epoll1_linux                      +48  +8.2%
  +0.3%     +32 src/core/lib/iomgr/ev_poll_posix.cc         +32  +0.3%
       +41%     +29 grpc_init_poll_posix                        +29   +41%
      +0.9%      +3 [Unmapped]                                   +3  +0.9%
  +1.2%     +16 src/core/lib/iomgr/ev_posix.cc              +16  +1.2%
      +5.7%     +11 [Unmapped]                                  +11  +5.7%
      +0.9%      +5 grpc_event_engine_init                       +5  +0.9%

  +0.1%    +760 TOTAL                                      +648  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-07T19:50:02Z

[trickle] No significant performance differences

grpc-testing · 2017-11-07T20:09:42Z

****************************************************************

libgrpc.so

     VM SIZE                                               FILE SIZE
 ++++++++++++++ GROWING                                 ++++++++++++++
  +0.1%    +433 [None]                                     +321  +0.0%
  +2.1%    +165 src/core/lib/iomgr/ev_epollsig_linux.cc    +165  +2.1%
       +59%    +165 grpc_init_epollsig_linux                   +165   +59%
  +0.6%     +66 src/core/lib/iomgr/ev_epollex_linux.cc      +66  +0.6%
       +50%     +66 grpc_init_epollex_linux                     +66   +50%
  +0.5%     +48 src/core/lib/iomgr/ev_epoll1_linux.cc       +48  +0.5%
      +8.2%     +48 grpc_init_epoll1_linux                      +48  +8.2%
  +0.3%     +32 src/core/lib/iomgr/ev_poll_posix.cc         +32  +0.3%
       +41%     +29 grpc_init_poll_posix                        +29   +41%
      +0.9%      +3 [Unmapped]                                   +3  +0.9%
  +1.2%     +16 src/core/lib/iomgr/ev_posix.cc              +16  +1.2%
      +5.7%     +11 [Unmapped]                                  +11  +5.7%
      +0.9%      +5 grpc_event_engine_init                       +5  +0.9%

  +0.1%    +760 TOTAL                                      +648  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-07T20:21:56Z

[trickle] No significant performance differences

grpc-testing · 2017-11-07T20:30:48Z

[microbenchmarks] No significant performance differences

grpc-testing · 2017-11-07T21:01:12Z

[microbenchmarks] No significant performance differences

grpc-testing · 2017-11-07T21:43:50Z

****************************************************************

libgrpc.so

     VM SIZE                                               FILE SIZE
 ++++++++++++++ GROWING                                 ++++++++++++++
  +0.1%    +433 [None]                                  +4.31Ki  +0.1%
  +2.1%    +165 src/core/lib/iomgr/ev_epollsig_linux.cc    +165  +2.1%
       +59%    +165 grpc_init_epollsig_linux                   +165   +59%
  +0.6%     +66 src/core/lib/iomgr/ev_epollex_linux.cc      +66  +0.6%
       +50%     +66 grpc_init_epollex_linux                     +66   +50%
  +0.5%     +48 src/core/lib/iomgr/ev_epoll1_linux.cc       +48  +0.5%
      +8.2%     +48 grpc_init_epoll1_linux                      +48  +8.2%
  +0.3%     +32 src/core/lib/iomgr/ev_poll_posix.cc         +32  +0.3%
       +41%     +29 grpc_init_poll_posix                        +29   +41%
      +0.9%      +3 [Unmapped]                                   +3  +0.9%
  +1.2%     +16 src/core/lib/iomgr/ev_posix.cc              +16  +1.2%
      +5.7%     +11 [Unmapped]                                  +11  +5.7%
      +0.9%      +5 grpc_event_engine_init                       +5  +0.9%

  +0.1%    +760 TOTAL                                   +4.63Ki  +0.1%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-07T21:55:21Z

[trickle] No significant performance differences

grpc-testing · 2017-11-07T22:14:12Z

****************************************************************

libgrpc.so

     VM SIZE                                               FILE SIZE
 ++++++++++++++ GROWING                                 ++++++++++++++
  +0.1%    +433 [None]                                  +4.32Ki  +0.1%
  +2.1%    +165 src/core/lib/iomgr/ev_epollsig_linux.cc    +165  +2.1%
       +59%    +165 grpc_init_epollsig_linux                   +165   +59%
  +0.6%     +66 src/core/lib/iomgr/ev_epollex_linux.cc      +66  +0.6%
       +50%     +66 grpc_init_epollex_linux                     +66   +50%
  +0.5%     +48 src/core/lib/iomgr/ev_epoll1_linux.cc       +48  +0.5%
      +8.2%     +48 grpc_init_epoll1_linux                      +48  +8.2%
  +0.3%     +32 src/core/lib/iomgr/ev_poll_posix.cc         +32  +0.3%
       +41%     +29 grpc_init_poll_posix                        +29   +41%
      +0.9%      +3 [Unmapped]                                   +3  +0.9%
  +1.2%     +16 src/core/lib/iomgr/ev_posix.cc              +16  +1.2%
      +5.7%     +11 [Unmapped]                                  +11  +5.7%
      +0.9%      +5 grpc_event_engine_init                       +5  +0.9%

  +0.1%    +760 TOTAL                                   +4.64Ki  +0.1%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-07T22:26:54Z

[trickle] No significant performance differences

grpc-testing · 2017-11-07T22:35:32Z

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_unary_ping_pong.BM_UnaryPingPong_InProcessCHTTP2_NoOpMutator_NoOpMutator__0_1.opt.old: 1


[microbenchmarks] No significant performance differences

grpc-testing · 2017-11-07T23:05:25Z

[microbenchmarks] No significant performance differences

grpc-testing · 2017-11-09T00:50:53Z

****************************************************************

libgrpc.so

     VM SIZE                                               FILE SIZE
 ++++++++++++++ GROWING                                 ++++++++++++++
  +0.1%    +401 [None]                                     +329  +0.0%
  +2.1%    +165 src/core/lib/iomgr/ev_epollsig_linux.cc    +165  +2.1%
       +59%    +165 grpc_init_epollsig_linux                   +165   +59%
  +0.6%     +66 src/core/lib/iomgr/ev_epollex_linux.cc      +66  +0.6%
       +50%     +66 grpc_init_epollex_linux                     +66   +50%
  +0.5%     +48 src/core/lib/iomgr/ev_epoll1_linux.cc       +48  +0.5%
      +8.2%     +48 grpc_init_epoll1_linux                      +48  +8.2%
  +0.3%     +32 src/core/lib/iomgr/ev_poll_posix.cc         +32  +0.3%
       +41%     +29 grpc_init_poll_posix                        +29   +41%
      +0.9%      +3 [Unmapped]                                   +3  +0.9%
  +1.2%     +16 src/core/lib/iomgr/ev_posix.cc              +16  +1.2%
      +5.7%     +11 [Unmapped]                                  +11  +5.7%
      +0.9%      +5 grpc_event_engine_init                       +5  +0.9%

  +0.1%    +728 TOTAL                                      +656  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-09T01:00:53Z

[trickle] No significant performance differences

grpc-testing · 2017-11-09T01:42:01Z

[microbenchmarks] No significant performance differences

yang-g · 2017-11-09T21:57:59Z

Test failures: #13124 #12510 #13330 #13253 #13338

yang-g assigned sreecha Nov 6, 2017

yang-g requested a review from sreecha November 6, 2017 22:37

googlebot added the cla: yes label Nov 6, 2017

sreecha suggested changes Nov 6, 2017

View reviewed changes

log GRPC_POLL_STRATEGY when fail to find polling engine

30101b0

also log reason to skip a polling engine

yang-g force-pushed the log_envar branch from eb85c32 to 30101b0 Compare November 6, 2017 23:13

sreecha approved these changes Nov 6, 2017

View reviewed changes

merge with head

56e7257

yang-g added the kokoro:force-run label Nov 7, 2017

kokoro-team removed the kokoro:force-run label Nov 7, 2017

remove unused variable

802f762

yang-g force-pushed the log_envar branch from f4c62a9 to 82f9b98 Compare November 7, 2017 21:40

include log.h for mac

ceb2475

yang-g force-pushed the log_envar branch from 82f9b98 to ceb2475 Compare November 7, 2017 22:11

Merge branch 'master' of https://github.com/grpc/grpc into log_envar

c3be930

yang-g merged commit 064bdd5 into grpc:master Nov 9, 2017

jaingaurav mentioned this pull request Dec 28, 2017

grpcio==1.8.x release logs messages that shouldn't be there #13855

Closed

mehrdada mentioned this pull request Dec 28, 2017

Relax log-level when polling engine is not defined #13882

Merged

lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019

lock bot unassigned sreecha Jan 21, 2019

Conversation

yang-g commented Nov 6, 2017

Uh oh!

grpc-testing commented Nov 6, 2017

Uh oh!

sreecha left a comment

Choose a reason for hiding this comment

Uh oh!

grpc-testing commented Nov 6, 2017

Uh oh!

grpc-testing commented Nov 6, 2017

Uh oh!

grpc-testing commented Nov 6, 2017

Uh oh!

grpc-testing commented Nov 7, 2017

Uh oh!

grpc-testing commented Nov 7, 2017

Uh oh!

grpc-testing commented Nov 7, 2017

Uh oh!

grpc-testing commented Nov 7, 2017

Uh oh!

grpc-testing commented Nov 7, 2017

Uh oh!

grpc-testing commented Nov 7, 2017

Uh oh!

grpc-testing commented Nov 7, 2017

Uh oh!

grpc-testing commented Nov 7, 2017

Uh oh!

grpc-testing commented Nov 7, 2017

Uh oh!

grpc-testing commented Nov 7, 2017

Uh oh!

grpc-testing commented Nov 7, 2017

Uh oh!

grpc-testing commented Nov 7, 2017

Uh oh!

grpc-testing commented Nov 7, 2017

Uh oh!

grpc-testing commented Nov 9, 2017

Uh oh!

grpc-testing commented Nov 9, 2017

Uh oh!

grpc-testing commented Nov 9, 2017

Uh oh!

yang-g commented Nov 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants