Fix php testWatchConnectivityState#13274
Merged
jtattermusch merged 1 commit intogrpc:masterfrom Nov 7, 2017
Merged
Conversation
Contributor
Author
|
CC @ctiller |
Contributor
Author
|
I filed #13275 for the C core issue. |
Contributor
Author
|
Known issues: |
Contributor
|
nice! thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12886.
The previous version of code was passing 'GPR_TIMESPAN' value as a deadline to C-core (which is treated as a timeout). Currently, that's probably broken, so changing to passing now() + timeout.
I tested locally and it seems to be fixing the issue even with timeout of 1000micro, but I wanted to be safe so I changed the timeout to 100ms.
We should probably file an issue for "passing GPR_TIMESPAN as a deadline" to C core not working correctly.