Remove src/node and references to it#13145
Merged
murgatroid99 merged 6 commits intogrpc:masterfrom Nov 7, 2017
Merged
Conversation
This removes all of the node code and tests from the repo, along with the scripts for running Node unit tests, performance tests, and artifact builds. The scripts for running tests from the grpc-node repository are untouched.
Contributor
|
What do you mean, the node test will fail ? |
|
Member
Author
|
I mean the test script that runs grpc-node unit tests with its submodule updated to this commit. I deleted the Node section of build.yaml. |
Contributor
|
Ah, I see, okay. |
|
|
|
|
|
|
|
|
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
|
|
Member
Author
|
@thelinuxfoundation Does pinging this bot make it check my CLA status again? |
|
nicolasnoble
approved these changes
Nov 2, 2017
|
|
matt-kwong
suggested changes
Nov 3, 2017
| @@ -1,28 +0,0 @@ | |||
| #!/bin/bash | |||
Contributor
There was a problem hiding this comment.
I don't think this is supposed to be deleted
Member
Author
There was a problem hiding this comment.
You're right. I fixed that.
|
|
|
|
matt-kwong
approved these changes
Nov 6, 2017
|
|
|
Member
Author
Member
|
This probably broke Artifact Build Linux |
This was referenced Nov 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all of the node code and tests from the repo, along with the scripts for running Node unit tests, performance tests, and artifact builds. The scripts for running unit and interop tests from the grpc-node repository are untouched.
We should eventually add Node back to the performance test script and have it run against grpc-node.
I expect the grpc-node test to fail, and probably to keep failing for a little while. It will take some work in that repo to make it compatible with this change.