Skip to content

Update boringssl submodule version#13105

Closed
illicitonion wants to merge 2 commits intogrpc:masterfrom
illicitonion:boringsslversion
Closed

Update boringssl submodule version#13105
illicitonion wants to merge 2 commits intogrpc:masterfrom
illicitonion:boringsslversion

Conversation

@illicitonion
Copy link
Copy Markdown

This includes several fixes for compiling with old versions of gcc, and
one for building with clang on OSX.

With this change, I was able to successfully run make grpc_cli.

@thelinuxfoundation
Copy link
Copy Markdown

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
The Linux Foundation CLA GitHub bot

@illicitonion
Copy link
Copy Markdown
Author

Signed linuxfoundation CLA and rebased. Please can someone take a look? Thanks!

@ctiller

@illicitonion
Copy link
Copy Markdown
Author

Is there anything I can do to get this going? Or any problems blocking it that aren't in a place I can see? @ctiller @nicolasnoble

@illicitonion
Copy link
Copy Markdown
Author

Pushed a rebase.

@illicitonion
Copy link
Copy Markdown
Author

Rebased again...

This includes several fixes for compiling with old versions of gcc, and
one for building with clang on OSX.
This is the output of running tools/buildgen/generate_projects.sh
@illicitonion
Copy link
Copy Markdown
Author

Rebased, included a handful more boringssl commits to pull in another compile fix.

@matt-kwong
Copy link
Copy Markdown
Contributor

Hi @illicitonion, I'm sorry this pull request didn't get any attention. We appreciate the pull request and should've given it attention when you created it.

I tried to update BoringSSL back in September with #12700, but at that time, there were some conflicts that stopped us from proceding, which we brought up with BoringSSL. I just recently was able to update BoringSSL with #13948 and #14256, so I hope this resolves any issue you may have had.

@matt-kwong matt-kwong closed this Feb 1, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants