Cleanup write path, fix some bugs#12856
Merged
ctiller merged 9 commits intogrpc:masterfrom Oct 11, 2017
Merged
Conversation
|
1 similar comment
|
|
|
|
|
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
|
|
|
|
|
|
|
|
|
|
|
1 similar comment
|
|
|
ncteisen
approved these changes
Oct 9, 2017
Contributor
ncteisen
left a comment
ncteisen
left a comment
There was a problem hiding this comment.
Small comments. LGTM otherwise, great re-write. It is a lot clearer to understand what's going on
| WriteContext *const write_context_; | ||
| grpc_chttp2_transport *const t_; | ||
| grpc_chttp2_stream *const s_; | ||
| bool sent_initial_metadata_; |
Contributor
There was a problem hiding this comment.
Can we just use s_->sent_initial_metadata?
Member
Author
There was a problem hiding this comment.
Good idea! More cleanup!
| } | ||
| } | ||
|
|
||
| bool WasLastFrame() const { return is_last_frame_; } |
| s_(s), | ||
| sending_bytes_before_(s_->sending_bytes) {} | ||
|
|
||
| uint32_t stream_remote_window() const { |
Contributor
There was a problem hiding this comment.
Tiny nit; why are stream_remote_window and max_outgoing snake case, but the rest of the new C++ camel?
Member
Author
There was a problem hiding this comment.
accessors and setters get snake_case, methods get CamelCase (see the final paragraph).
|
|
|
Member
Author
|
The bm_diff output looks a little too good: I want to peek further and ensure this is right before submitting |
|
|
Member
Author
|
Failures seem to be existing things, and this fixes some P0's |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to fix: #12510 #12428 #11737