Skip to content

run_tests.py: embed openssl during building c-core before running build_php.sh#12495

Merged
ZhouyihaiDing merged 1 commit intogrpc:masterfrom
ZhouyihaiDing:build_php
Sep 18, 2017
Merged

run_tests.py: embed openssl during building c-core before running build_php.sh#12495
ZhouyihaiDing merged 1 commit intogrpc:masterfrom
ZhouyihaiDing:build_php

Conversation

@ZhouyihaiDing
Copy link
Copy Markdown
Contributor

@ZhouyihaiDing ZhouyihaiDing commented Sep 11, 2017

When running tools/run_tests/run_performance_tests.py, libgrpc.so has link issues:

        linux-vdso.so.1 =>  (0x00007ffe3ffee000)
        libssl.so.1.0.0 => /lib/x86_64-linux-gnu/libssl.so.1.0.0 (0x00007f57c19dd000)
        libcrypto.so.1.0.0 => /lib/x86_64-linux-gnu/libcrypto.so.1.0.0 (0x00007f57c1599000)
        librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f57c1391000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f57c1088000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f57c0e6a000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f57c0aa1000)
        /lib64/ld-linux-x86-64.so.2 (0x0000562093469000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f57c089d000)

after this change,

        linux-vdso.so.1 =>  (0x00007ffe42558000)
        librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f4b92b44000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f4b9283b000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f4b9261d000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f4b92256000)
        /lib64/ld-linux-x86-64.so.2 (0x0000556e4c569000)

@ZhouyihaiDing ZhouyihaiDing mentioned this pull request Sep 11, 2017
Merged
stanley-cheung
stanley-cheung reviewed Sep 11, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jtattermusch PTAL as well.

jtattermusch
jtattermusch approved these changes Sep 12, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jtattermusch jtattermusch changed the title run_performance_tests: embed openssl during building c-core before running build_php.sh run_tests.py: embed openssl during building c-core before running build_php.sh Sep 12, 2017
@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Sep 13, 2017 

[trickle] No significant performance differences

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Sep 13, 2017 

[microbenchmarks] No significant performance differences

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Sep 14, 2017 

[trickle] No significant performance differences

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Sep 14, 2017 

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPong_MinTCP_NoOpMutator_NoOpMutator__8_1.opt.new: 1
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_TCP__2M.counters.new: 1


[microbenchmarks] No significant performance differences

@ZhouyihaiDing
Copy link
Copy Markdown
Contributor Author

ZhouyihaiDing commented Sep 14, 2017 •
edited
Loading

#12428 #12578

@ZhouyihaiDing ZhouyihaiDing force-pushed the build_php branch 2 times, most recently from 338e2fb to a2d0eea Compare September 14, 2017 21:15
@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Sep 14, 2017 

[trickle] No significant performance differences

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Sep 14, 2017 

[microbenchmarks] Performance differences noted:
Benchmark                                  real_time
-----------------------------------------  -----------
BM_PumpStreamClientToServer<SockPair>/512  +4%

@ZhouyihaiDing ZhouyihaiDing force-pushed the build_php branch 3 times, most recently from 47d3b6a to e9586ab Compare September 15, 2017 18:30
@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Sep 15, 2017 

[trickle] No significant performance differences

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Sep 15, 2017 

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__2M_2_0.opt.old: 1


[microbenchmarks] No significant performance differences

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Sep 18, 2017 

[trickle] No significant performance differences

This was referenced Sep 18, 2017
Closed
Closed
Closed
Closed
@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Sep 18, 2017 

[microbenchmarks] Performance differences noted:
Benchmark                                                      atm_add_per_iteration    nows_per_iteration
-------------------------------------------------------------  -----------------------  --------------------
BM_PumpStreamServerToClient<TCP>/16M                           -4%
BM_StreamingPingPongMsgs<MinTCP, NoOpMutator, NoOpMutator>/2M  -4%                      -6%

@ZhouyihaiDing
Copy link
Copy Markdown
Contributor Author

ZhouyihaiDing commented Sep 18, 2017

Tests are failing with known issues:
gRPC_interop_pull_requests - #12617 #12618
Basic Tests Multi-language Linux (internal CI) - #12619
Tsan C++ - #12510
Msan C (internal CI) - #12394
Tsan C (internal CI) - #12544
Basic Tests Linux (dbg) - #12619 #12510
Basic Tests Linux (opt) - #12619 #12510
Basic Tests Mac - #12619 - #12619
Basic Tests MacOS [dbg] (internal CI) - #12619
Basic Tests MacOS [opt] (internal CI) - #12619
Basic Tests Windows - #12620
Basic Tests Windows (internal CI) -
Basic Tests C & C++ Linux [opt] (internal CI) - #12313
Basic Tests C & C++ Linux [dbg] (internal CI) - #12461

@ZhouyihaiDing ZhouyihaiDing merged commit 63f31e8 into grpc:master Sep 18, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stanley-cheung stanley-cheung stanley-cheung left review comments

+1 more reviewer

@jtattermusch jtattermusch jtattermusch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ZhouyihaiDing @grpc-kokoro @jtattermusch @stanley-cheung @googlebot