Set full path to protoc inside _gRPC_PROTOBUF_PROTOC variable, so it … by kskalski · Pull Request #11891 · grpc/grpc

kskalski · 2017-07-20T17:57:35Z

…can work for both MODULE and PACKAGE type of protobuf provider.

grpc-testing · 2017-07-20T17:59:05Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-07-20T17:59:13Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-07-20T17:59:20Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-07-20T18:00:06Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-07-20T18:00:15Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-07-20T18:00:24Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-07-20T18:01:05Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-07-20T18:02:14Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-07-20T18:03:05Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-07-20T18:04:05Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-07-20T18:05:04Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-07-20T18:05:24Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-07-20T18:05:32Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-07-20T18:06:05Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-07-20T18:07:05Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-07-20T18:07:14Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-07-26T21:08:20Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

jtattermusch · 2017-08-24T12:28:04Z

CMakeLists.txt

             "${_gRPC_PROTO_GENS_DIR}/${RELFIL_WE}.pb.cc"
             "${_gRPC_PROTO_GENS_DIR}/${RELFIL_WE}.pb.h"
-      COMMAND $<TARGET_FILE:${_gRPC_PROTOBUF_PROTOC}>
+      COMMAND ${_gRPC_PROTOBUF_PROTOC}


why remove the $<TARGET_FILE: >?

When running with cmake . -DgRPC_PROTOBUF_PROVIDER=package -DgRPC_ZLIB_PROVIDER=package -DgRPC_SSL_PROVIDER=package
I get

CMake Error at CMakeLists.txt:336 (add_custom_command):
Error evaluating generator expression:

$<TARGET_FILE:/usr/bin/protoc>

When {_gRPC_PROTOBUF_PROTOC} point to absolute path then prefixing it with anything doesn't make sense. I'm not sure what was the original intention of using TARGET_FILE here, I guess it accidentally pointed to the same directory as PROTOBUF_ROOT_DIR

jtattermusch · 2017-08-24T12:29:00Z

CMakeLists.txt

    endif()
    if(TARGET protoc)
-      set(_gRPC_PROTOBUF_PROTOC protoc)
+      set(_gRPC_PROTOBUF_PROTOC ${PROTOBUF_ROOT_DIR}/protoc)


Is that really where protoc will be located if I build protobuf as a submodule?

This variable is set to:
set(PROTOBUF_ROOT_DIR ${CMAKE_CURRENT_SOURCE_DIR}/third_party/protobuf)
and that directory gets protoc placed in it:
$ ls third_party/protobuf/protoc -l
-rwxr-xr-x 1 pi pi 9397460 Jul 20 18:53 third_party/protobuf/protoc

At least this is what happens when I build with this setting

jtattermusch · 2017-09-11T08:59:38Z

Should be fixed by #12411

Set full path to protoc inside _gRPC_PROTOBUF_PROTOC variable, so it …

f6cc20e

…can work for both MODULE and PACKAGE type of protobuf provider.

googlebot added the cla: yes label Jul 20, 2017

kskalski referenced this pull request Jul 20, 2017

explicitly use built protoc for CMake build

6fe1d80

OgreTransporter mentioned this pull request Aug 20, 2017

CMake: Error evaluating generator expression for protoc package #12230

Closed

jtattermusch self-requested a review August 24, 2017 12:21

jtattermusch self-assigned this Aug 24, 2017

jtattermusch added the kokoro:run label Aug 24, 2017

jtattermusch reviewed Aug 24, 2017

View reviewed changes

kokoro-team removed the kokoro:run label Aug 27, 2017

jtattermusch mentioned this pull request Sep 6, 2017

cmake: choose the right protoc executable with gRPC_PROTOBUF_PROVIDER=package #12411

Merged

jtattermusch closed this Sep 11, 2017

lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019

Conversation

kskalski commented Jul 20, 2017

Uh oh!

grpc-testing commented Jul 20, 2017

Uh oh!

grpc-kokoro commented Jul 20, 2017

Uh oh!

grpc-testing commented Jul 20, 2017

Uh oh!

grpc-kokoro commented Jul 20, 2017

Uh oh!

grpc-testing commented Jul 20, 2017

Uh oh!

grpc-kokoro commented Jul 20, 2017

Uh oh!

grpc-kokoro commented Jul 20, 2017

Uh oh!

grpc-kokoro commented Jul 20, 2017

Uh oh!

grpc-kokoro commented Jul 20, 2017

Uh oh!

grpc-kokoro commented Jul 20, 2017

Uh oh!

grpc-testing commented Jul 20, 2017

Uh oh!

grpc-kokoro commented Jul 20, 2017

Uh oh!

grpc-kokoro commented Jul 20, 2017

Uh oh!

grpc-testing commented Jul 20, 2017

Uh oh!

grpc-testing commented Jul 20, 2017

Uh oh!

grpc-kokoro commented Jul 20, 2017

Uh oh!

grpc-kokoro commented Jul 26, 2017

Uh oh!

jtattermusch Aug 24, 2017

Choose a reason for hiding this comment

Uh oh!

kskalski Aug 24, 2017

Choose a reason for hiding this comment

Uh oh!

jtattermusch Aug 24, 2017

Choose a reason for hiding this comment

Uh oh!

kskalski Aug 24, 2017

Choose a reason for hiding this comment

Uh oh!

jtattermusch commented Sep 11, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants