Skip to content

add imported target for protoc if not provided by FindProtobuf#11794

Closed
hesmar wants to merge 1 commit intogrpc:masterfrom
hesmar:add_protoc_target
Closed

add imported target for protoc if not provided by FindProtobuf#11794
hesmar wants to merge 1 commit intogrpc:masterfrom
hesmar:add_protoc_target

Conversation

@hesmar
Copy link
Copy Markdown
Contributor

@hesmar hesmar commented Jul 13, 2017

$<TARGET_FILE:${_gRPC_PROTOBUF_PROTOC}> fails if ${_gRPC_PROTOBUF_PROTOC} is not a target. This PR adds an imported target if FindProtobuf does not provide it.

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

13 similar comments
@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@googlebot
Copy link
Copy Markdown

googlebot commented Jul 13, 2017

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@hesmar hesmar force-pushed the add_protoc_target branch from 6577b20 to f9c04ac Compare July 13, 2017 10:43
@googlebot
Copy link
Copy Markdown

googlebot commented Jul 13, 2017

CLAs look good, thanks!

@hesmar hesmar mentioned this pull request Jul 13, 2017
Merged
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 13, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@jtattermusch jtattermusch self-assigned this Jul 13, 2017
@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Jul 13, 2017

test this please

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Jul 13, 2017 

[trickle] No significant performance differences

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Jul 13, 2017 

[microbenchmarks] No significant performance differences

@hesmar hesmar force-pushed the add_protoc_target branch from f9c04ac to 527a01e Compare July 13, 2017 11:52
@jtattermusch jtattermusch mentioned this pull request Sep 6, 2017
Merged
@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Sep 11, 2017

should be fixed by #12411

@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jtattermusch jtattermusch

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hesmar @grpc-kokoro @grpc-testing @googlebot @jtattermusch