Increase CMake build portability and improve support for FreeBSD#10724
Merged
mehrdada merged 1 commit intogrpc:masterfrom Apr 20, 2017
mehrdada:freebsd-support
Merged
Increase CMake build portability and improve support for FreeBSD#10724mehrdada merged 1 commit intogrpc:masterfrom mehrdada:freebsd-support
mehrdada merged 1 commit intogrpc:masterfrom
mehrdada:freebsd-support
Conversation
mehrdada
changed the title
Collaborator
|
3 similar comments
Collaborator
|
Collaborator
|
Collaborator
|
mehrdada
changed the title
jtattermusch
approved these changes
Apr 20, 2017
Contributor
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM, but I see some tests failing, so please doublecheck before merging.
- Update CMakeLists.txt (original template and generated code)
to prevent forcefully linking `dl` on all UNIX platforms,
and rely on `${CMAKE_DL_LIBS}` portable variable instead.
- Do not try linking against `librt` on macOS.
- Add a `config_freebsd` directory containing the header file
generated by the `configure` script for the `ares` library.
mitsutaka-takeda
pushed a commit
to mitsutaka-takeda/grpc
that referenced
this pull request
Jun 30, 2017
Caused by errorneous cmake scripts. This pull request fixed the issued and merged into the master. grpc#10724
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMakeLists.txt(and its template) to prevent trying to linkdllibrary on all UNIX platforms, causing build to fail on FreeBSD (or other similar platforms) where such library is non-existent. Instead, rely on the portable CMake variable${CMAKE_DL_LIBS}.librtwhich is unavailable.config_freebsddirectory containing the header file generated by theconfigurescript forareslibrary.Works toward fixing #9721