Skip to content

Fix c-ares ruby artifact build on v1.3.x#10719

Merged
y-zeng merged 1 commit intogrpc:v1.3.xfrom
y-zeng:fix_ruby_13
Apr 20, 2017
Merged

Fix c-ares ruby artifact build on v1.3.x#10719
y-zeng merged 1 commit intogrpc:v1.3.xfrom
y-zeng:fix_ruby_13

Conversation

@y-zeng
Copy link
Copy Markdown
Contributor

@y-zeng y-zeng commented Apr 18, 2017

Cherry-picks #10710 onto v1.3.x

@y-zeng y-zeng requested a review from apolcyn April 18, 2017 22:24
@y-zeng y-zeng mentioned this pull request Apr 18, 2017
Closed
@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Apr 19, 2017 

Performance differences noted:
Benchmark                                               cpu_time    real_time
----------------------------------------------------  ----------  -----------
BM_HpackParserParseHeader<IndexedSingleInternedElem>       -7.00        -7.00
BM_TransportStreamRecv/0                                 +128.50      +129.00
BM_TransportStreamRecv/1                                 +111.00      +111.00
BM_TransportStreamRecv/64                                +164.50      +164.50
BM_TransportStreamRecv/8                                 +203.50      +203.50

@y-zeng
Copy link
Copy Markdown
Contributor Author

y-zeng commented Apr 20, 2017

Known issues:
Basic Tests Mac: #10202
gRPC_interop_pull_requests: #10576

@y-zeng y-zeng merged commit dfa070f into grpc:v1.3.x Apr 20, 2017
@y-zeng y-zeng mentioned this pull request Apr 20, 2017
Closed
jtattermusch added a commit to jtattermusch/grpc that referenced this pull request Aug 29, 2017
@jtattermusch
reintroduce ares_build.h modification from grpc#10719
825ad4d
jtattermusch added a commit to jtattermusch/grpc that referenced this pull request Sep 6, 2017
@jtattermusch
reintroduce ares_build.h modification from grpc#10719
e0b0d75
jtattermusch added a commit to jtattermusch/grpc that referenced this pull request Sep 9, 2017
@jtattermusch
reintroduce ares_build.h modification from grpc#10719
bb650ca
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@apolcyn apolcyn apolcyn approved these changes

Assignees

@apolcyn apolcyn

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@y-zeng @grpc-kokoro @apolcyn @googlebot