Skip to content

Fix c-ares ruby artifact build#10710

Closed
y-zeng wants to merge 1 commit intogrpc:masterfrom
y-zeng:ruby_build
Closed

Fix c-ares ruby artifact build#10710
y-zeng wants to merge 1 commit intogrpc:masterfrom
y-zeng:ruby_build

Conversation

@y-zeng
Copy link
Copy Markdown
Contributor

@y-zeng y-zeng commented Apr 18, 2017 •
edited
Loading

  • Add c-ares mingw32 support
  • Undefine UNICODE and _UNICODE in ares_build.h. c-ares defines some ANSI string macros but does not explicitly use the ANSI version of the following functions:
    • RegQueryValueEx
    • ExpandEnvironmentStrings
    • GetWindowsDirectory
    • RegEnumKeyEx
    • RegOpenKeyEx

@y-zeng y-zeng requested a review from apolcyn April 18, 2017 20:03
@apolcyn
Copy link
Copy Markdown
Contributor

apolcyn commented Apr 18, 2017

thanks! can we move this to be against v1.3.x? I think it will be needed for the 1.3 builds

@y-zeng y-zeng mentioned this pull request Apr 18, 2017
Merged
@y-zeng
Copy link
Copy Markdown
Contributor Author

y-zeng commented Apr 18, 2017

#10719 cherry-picks this change to v1.3.x

@y-zeng y-zeng closed this Apr 21, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@apolcyn apolcyn Awaiting requested review from apolcyn

Assignees

@apolcyn apolcyn

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@y-zeng @apolcyn @googlebot