-
Notifications
You must be signed in to change notification settings - Fork 11.1k
service_config_test fails on gcc4.8 #20318
Copy link
Copy link
Closed
Labels
disposition/BUILDNURSEFor all buildnurse related build/test failures and flakesFor all buildnurse related build/test failures and flakesinfra/New Failurekind/buglang/c++priority/P2
Description
What version of gRPC and what language are you using?
C++, latest version
What operating system (Linux, Windows,...) and version?
Linux
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc4.8
What did you do?
Looked at our portability suite runs on master and saw the gcc4.8 tests failing on master because of the service_config_test
Local repro: sudo tools/run_tests/run_tests.py -c dbg --compiler gcc4.8 --regex service_config_test -l c++ --use_docker -j 8
What did you expect to see?
The test should pass
What did you see instead?
The test fails.
The issue is that std::regex doesn't functionally work in gcc4.8, although it compiles.
I'm making a workaround that skips the test for gcc4.8. However, I recommend either:
- yashkt@ confirming that the test behavior should be identical across compilers and closing this bug or
- Reworking the test to use something besides std::regex when running under gcc4.8
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
disposition/BUILDNURSEFor all buildnurse related build/test failures and flakesFor all buildnurse related build/test failures and flakesinfra/New Failurekind/buglang/c++priority/P2