-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Bazel 0.20 fixes into release 1.17.x [request] #17445
Copy link
Copy link
Closed
Labels
Description
What version of gRPC and what language are you using?
I'm using gRPC from commit f8696b5 (author: @nicolasnoble, reviewer: @jtattermusch)
which is from #17363 which fixes an issue with Bazel 0.20.0
This is my WORKSPACE file:
##
# We need a specific unreleased version of gRPC:
# which fixes grpc & bazel 0.20 issues
# https://github.com/grpc/grpc/pull/17363
##
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
name = 'com_github_grpc_grpc',
url = 'https://github.com/grpc/grpc/archive/f8696b5136108fd2d46e553fdd550e1be6ba2677.zip',
sha256 = 'e8484fba47a3eebaed82704e8197a5f98f20d6843e44ea2a5e007180958ad545',
strip_prefix = 'grpc-f8696b5136108fd2d46e553fdd550e1be6ba2677',
)
load("@com_github_grpc_grpc//bazel:grpc_deps.bzl", "grpc_deps")
grpc_deps()
What operating system (Linux, Windows, …) and version?
Ubuntu 18.04 & Ubuntu 14.04
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc 7.3.0
What did you do?
We were using grpc, with a specific release specified in our WORKSPACE (1.14.2) file, but then we upgraded to Bazel 0.20.0 and it failed due to deprecated imports of the grpc_deps.
What did you expect to see?
To be able to continue using a released version of gRPC.
It would be better to point to a specific release: 1.17.0 was released just after #17363 went it, so I first tried the latest release 1.17.0 but that also didn't work.
What did you see instead?
It didn't compile, but I find the fix had been merged to master with: f8696b5
Anything else we should know about your project / environment?
could f8696b5 get cherry-picked into 1.17.1
Reactions are currently unavailable