clear_depth, depth_range with auto select the best function#310
Merged
grovesNL merged 2 commits intogrovesNL:mainfrom Oct 16, 2024
Merged
clear_depth, depth_range with auto select the best function#310grovesNL merged 2 commits intogrovesNL:mainfrom
grovesNL merged 2 commits intogrovesNL:mainfrom
Conversation
3 tasks
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
sagudev
force-pushed
the
depth-auto-type
branch
from
a0c14d6 to
7f7b510
Compare
Contributor
Author
|
Gentle ping @grovesNL |
Contributor
Author
|
Would it be possible to get this released too? 🥺 |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would be useful for servo as sparkle also did this: https://github.com/servo/sparkle/blob/a61f94fff95d29e93721cdbfc4b5dde8671a6970/src/lib.rs#L736. All OpenGL versions supports f64 variant, but only 4.1>= supports f32 variant, while GLES supports only f32 variant
Second commit uses
supports_f64_precisionfor auto selection and fixessupports_f64_precisionon native for GLES to return false, but it's breaking change (as it needs &self now), although I did not find any users of it on whole GitHub.