package yum: keep SRPM paths for backward compatibility by otegami · Pull Request #2558 · groonga/groonga

otegami · 2025-10-10T08:00:00Z

Apache Arrow changed SRPM output location from source/SRPMS/ to Source/Packages/.

ref: GH-47582: [CI][Packaging] Move linux-packaging tasks to apache/arrow repository apache/arrow#47600

This change breaks Yum repository compatibility for existed distributions. This commit adds path management after yum:build to maintain compatibility:

For AlmaLinux 10 and earlier and Amazon Linux 2023: Rename SRPMs path from Source/Packages/ to source/ for backward compatibility
For AlmaLinux 11 and later: Uses the new Source/Packages/ path
Except for x86 architecture: Removes SRPMs

Apache Arrow changed SRPM output location from 'Source/Packages/' to 'source/SRPMS/'. This change breaks Yum repository compatibility for existing AlmaLinux distributions. This commit adds path management after yum:build to maintain compatibility: - For AlmaLinux 10 and earlier: Rename source/SRPMS/ to Source/Packages/ - For AlmaLinux 11 and later: Uses the new source/SRPMS/ structure - For aarch64 architecture: Removes SRPMs

otegami · 2025-10-12T08:53:56Z

Before this PR

$ tree packages-almalinux-8-x86_64.new/
packages-almalinux-8-x86_64.new/
├── almalinux-8-x86_64
│   └── packages
│       └── yum
│           └── repositories
│               └── almalinux
│                   └── 8
│                       ├── Source
│                       │   └── Packages
│                       │       └── groonga-15.1.8-1.el8.src.rpm
│                       └── x86_64
│                           └── Packages
│                               ├── groonga-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-debuginfo-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-debugsource-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-devel-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-doc-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-examples-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-libs-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-libs-debuginfo-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-munin-plugins-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-plugin-h3-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-plugin-h3-debuginfo-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-plugin-suggest-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-plugin-suggest-debuginfo-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-server-common-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-server-gqtp-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-server-http-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-token-filter-stem-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-token-filter-stem-debuginfo-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-tokenizer-mecab-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-tokenizer-mecab-debuginfo-15.1.8-1.el8.x86_64.rpm
│                               └── groonga-tools-15.1.8-1.el8.x86_64.rpm
└── almalinux-8-x86_64.tar.gz

11 directories, 23 files

After this PR

$ tree packages-almalinux-8-x86_64/
packages-almalinux-8-x86_64/
├── almalinux-8-x86_64
│   └── packages
│       └── yum
│           └── repositories
│               └── almalinux
│                   └── 8
│                       ├── source
│                       │   └── SRPMS
│                       │       └── groonga-15.1.8-1.el8.src.rpm
│                       └── x86_64
│                           └── Packages
│                               ├── groonga-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-debuginfo-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-debugsource-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-devel-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-doc-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-examples-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-libs-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-libs-debuginfo-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-munin-plugins-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-plugin-h3-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-plugin-h3-debuginfo-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-plugin-suggest-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-plugin-suggest-debuginfo-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-server-common-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-server-gqtp-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-server-http-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-token-filter-stem-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-token-filter-stem-debuginfo-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-tokenizer-mecab-15.1.8-1.el8.x86_64.rpm
│                               ├── groonga-tokenizer-mecab-debuginfo-15.1.8-1.el8.x86_64.rpm
│                               └── groonga-tools-15.1.8-1.el8.x86_64.rpm
└── almalinux-8-x86_64.tar.gz

11 directories, 23 files

kou · 2025-10-12T12:23:42Z

packages/packages-groonga-org-package-task.rb


+  def yum_build(console: false)
+    super
+    manage_srpm_paths_for_compatibility


manageってどういうニュアンスで使っていますか？
私は「なんとかする」くらいの意味だと思っています。もしそういうニュアンスで使っているなら、そういうふわっとした意味よりもっと明確な操作を示す単語を使って欲しいです。

keep_srpm_path_compatibilityとか？

ありがとうございます。
次の2つの作業をやらせていたので、manageを利用していました。
fix: 81066b0 ただここでは、互換性に関する処理だけを行いたいので、keep_xxに変更します。
fix: a70ed92 削除自体も別に切り出して対応します。

互換性のためにパスを変更する

ARM64環境では、SRPMを削除する

fix: e015dc0 2回同じループを回すのが引っかかったので、manage_srpm_pathsで互換性の処理とARM64環境の対応を合わせて対応させてみました。
（変更前のほうが何をするかすぐにわかりやすいかなとも思っているので少し悩んでいます。）

遅い処理でもなく、速度が求められる処理でもないので、読みやすさを犠牲にするメリットがないです。そのため、一緒にしなくていいっす。

こういう読みやすさを犠牲にする最適化をするべきかどうかという判断をするときは、そもそも遅くて困っているのか？困っているならどのくらい速くしないといけないのかとかを考えるべきです。一般的には。

たとえば、こういう開発用のツールとか、そもそもループで回すものが少ないときは、最適化する必要がないことが多いです。一方、Groongaの全文検索関連の処理とかは速さがマジで重要で、扱うデータ量も多いので、読みやすさを犠牲にしてでもがんばらないといけないという判断が必要なときが多々あります。

fix: 22db6ba
ありがとうございます。今後、Groongaだけに閉じずに開発する際に意識していこうと思います！

kou · 2025-10-12T12:30:13Z

packages/packages-groonga-org-package-task.rb

+      # Backward compatibility: only rename for existing distributions that
+      # still expect the legacy SRPM structure.
+      # Legacy (<= AlmaLinux 10): source/SRPMS
+      # New    (>= AlmaLinux 11): Source/Packages (no rename needed)
+      next if distribution != "almalinux"


この条件だとAlmaLinux 11でもリネームしませんか？

現状で対応しているディストリビューションが以下なので、これらはリネームし、それ以外は何もしない、がいいです。

groonga/packages/Rakefile

Lines 67 to 78 in cb83ebf

def yum_targets_default

[

"almalinux-8",

"almalinux-8-aarch64",

"almalinux-9",

"almalinux-9-aarch64",

"almalinux-10",

"almalinux-10-aarch64",

"amazon-linux-2023",

"amazon-linux-2023-aarch64",

]

end

今の実装だとAmazonLinuxのことは考慮していないですよね。

Suggested change

# Backward compatibility: only rename for existing distributions that

# still expect the legacy SRPM structure.

# Legacy (<= AlmaLinux 10): source/SRPMS

# New (>= AlmaLinux 11): Source/Packages (no rename needed)

next if distribution != "almalinux"

# Rename SRPM directory only for the following distributions

# to keep backward compatibility:

#

# * AlmaLinux 8

# * AlmaLinux 9

# * AlmaLinux 10

# * Amazon Linux 2023

#

# They keep using source/SRPMS/*.src.rpm for SRPM path.

case "#{distribution}-#{version}"

when "almalinux-8",

"almalinux-9",

"almalinux-10",

"amazon-linux-2023"

next

end

fix: af2933d 対応するディストリビューションを明示的に記載するように修正しています。

packages/packages-groonga-org-package-task.rb

kou · 2025-10-12T12:35:03Z

packages/packages-groonga-org-package-task.rb

+      repo_base = "#{repositories_dir}/#{distribution}/#{version}"
+      old_path = "#{repo_base}/source/SRPMS"
+      new_path = "#{repo_base}/Source/Packages"


old_path/new_pathにするならrepo_baseもXXX_pathにしませんか？

Suggested change

repo_base = "#{repositories_dir}/#{distribution}/#{version}"

old_path = "#{repo_base}/source/SRPMS"

new_path = "#{repo_base}/Source/Packages"

base_path = "#{repositories_dir}/#{distribution}/#{version}"

old_path = "#{base_path}/source/SRPMS"

new_path = "#{base_path}/Source/Packages"

fix: 15485bb pathの名前に関しては一貫して、xx_pathを利用するように修正しました。

… backward compatibility

otegami · 2025-10-14T02:33:52Z

ここまで頂いたレビューコメントの対応を行いました。
改めて期待通り動作しているのか、x86とaarch64環境で確認を行いました。

動作確認ログ

$ tree almalinux-8-x86_64/
almalinux-8-x86_64/
└── packages
    └── yum
        └── repositories
            └── almalinux
                └── 8
                    ├── source
                    │   └── SRPMS
                    │       └── groonga-15.1.8-1.el8.src.rpm
                    └── x86_64
                        └── Packages
                            ├── groonga-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-debuginfo-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-debugsource-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-devel-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-doc-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-examples-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-libs-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-libs-debuginfo-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-munin-plugins-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-plugin-h3-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-plugin-h3-debuginfo-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-plugin-suggest-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-plugin-suggest-debuginfo-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-server-common-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-server-gqtp-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-server-http-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-token-filter-stem-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-token-filter-stem-debuginfo-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-tokenizer-mecab-15.1.8-1.el8.x86_64.rpm
                            ├── groonga-tokenizer-mecab-debuginfo-15.1.8-1.el8.x86_64.rpm
                            └── groonga-tools-15.1.8-1.el8.x86_64.rpm

10 directories, 22 files

$ tree almalinux-8-aarch64/
almalinux-8-aarch64/
└── packages
    └── yum
        └── repositories
            └── almalinux
                └── 8
                    └── aarch64
                        └── Packages
                            ├── groonga-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-debuginfo-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-debugsource-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-devel-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-doc-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-examples-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-libs-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-libs-debuginfo-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-munin-plugins-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-plugin-h3-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-plugin-h3-debuginfo-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-plugin-suggest-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-plugin-suggest-debuginfo-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-server-common-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-server-gqtp-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-server-http-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-token-filter-stem-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-token-filter-stem-debuginfo-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-tokenizer-mecab-15.1.8-1.el8.aarch64.rpm
                            ├── groonga-tokenizer-mecab-debuginfo-15.1.8-1.el8.aarch64.rpm
                            └── groonga-tools-15.1.8-1.el8.aarch64.rpm

8 directories, 21 files

- achitectures + architectures

otegami · 2025-10-14T02:45:27Z

fix: ce5b45b I will fix typos.

This reverts commit e015dc0. We don't have to persue the speed here because there are not a lot of distibutions. Readability is more important.

kou · 2025-10-14T04:45:59Z

packages/packages-groonga-org-package-task.rb

+      else
+        next


Suggested change

else

next

明示的にコメントだけ入れるようにしてみました。
" # Use latest SRPM path for other distributions Source/Packages/*.src.rpm"

packages/packages-groonga-org-package-task.rb

kou · 2025-10-14T04:51:36Z

packages/packages-groonga-org-package-task.rb

+    repositories_path = "#{yum_dir}/repositories"
+    yum_targets.each do |target|
+      distribution, version, architecture = split_target(target)
+      next if architecture != "aarch64"


やりたいことはSRPMは1つだけ残して全部消したい、なので、aarch64だけ消す、じゃなくて、x86_64以外は消すというコードにしませんか？（オリジナルのコードも[ "${ARCHITECTURE}" != "x86_64" ]なのでそういう意図のコードになっていました。）

x86_64のときはarchitectureがnilになる気がするのでnext unless architecture.nil?かな。

やりたいことはSRPMは1つだけ残して全部消したい

fix: 2c13cb2 ありがとうございます。なるほどです。aarch64の場合だけ削除すると捉えてしまっていたのですが、本質的には何をやりたいのかちゃんと理解できていなかったですmm

packages/packages-groonga-org-package-task.rb

- description + distribution

otegami · 2025-10-14T05:48:31Z

ここまで頂いたレビューコメントの対応を行いました。

Copilot

Pull Request Overview

This PR refactors SRPM (Source RPM) path management from a shell script approach to Ruby methods to handle backward compatibility with different AlmaLinux distributions following Apache Arrow's SRPM location changes.

Moves SRPM path management logic from GitHub Actions workflow to Ruby methods in the package task
Implements distribution-specific path handling for AlmaLinux 8-10 and Amazon Linux 2023
Replaces shell-based SRPM removal for non-x86_64 architectures with Ruby implementation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
packages/packages-groonga-org-package-task.rb	Adds Ruby methods for SRPM path compatibility and architecture-specific removal
.github/workflows/package.yml	Removes shell script logic for SRPM handling from the workflow

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-14T23:50:58Z

packages/packages-groonga-org-package-task.rb

+        old_path = "#{distribution_path}/source/SRPMS"
+        new_path = "#{distribution_path}/Source/Packages"
+        mkdir_p(File.dirname(old_path))
+        mv(new_path, old_path)
+        rm_rf(File.dirname(new_path))


The variable names old_path and new_path are confusing as they don't reflect the actual operation. The code moves from Source/Packages (new_path) to source/SRPMS (old_path), but semantically this is moving from the new format to the old format for backward compatibility. Consider renaming to backward_compatible_path and new_arrow_path for clarity.

Suggested change

old_path = "#{distribution_path}/source/SRPMS"

new_path = "#{distribution_path}/Source/Packages"

mkdir_p(File.dirname(old_path))

mv(new_path, old_path)

rm_rf(File.dirname(new_path))

backward_compatible_path = "#{distribution_path}/source/SRPMS"

new_arrow_path = "#{distribution_path}/Source/Packages"

mkdir_p(File.dirname(backward_compatible_path))

mv(new_arrow_path, backward_compatible_path)

rm_rf(File.dirname(new_arrow_path))

backward_compatible_path is easier to understand.

fix: 96fc07b Thanks!

packages/packages-groonga-org-package-task.rb

otegami · 2025-10-15T00:20:56Z

ここまで頂いたレビューコメントの対応を行いました。

kou · 2025-10-15T08:17:49Z

packages/packages-groonga-org-package-task.rb

+    keep_srpm_paths_for_compatibility
+    remove_srpm_from_arm_architectures


Could you add yum_ prefix?

Suggested change

keep_srpm_paths_for_compatibility

remove_srpm_from_arm_architectures

yum_keep_srpm_paths_for_compatibility

yum_remove_srpm_from_arm_architectures

fix: 1ca7a60 Sure!

kou · 2025-10-15T08:19:12Z

packages/packages-groonga-org-package-task.rb

+        mv(new_path, backward_compatible_path)
+        rm_rf(File.dirname(new_path))
+      else
+        # Use latest SRPM path for other distributions Source/Packages/*.src.rpm


Suggested change

# Use latest SRPM path for other distributions Source/Packages/*.src.rpm

# Use SRPM path as-is for other distributions: Source/Packages/*.src.rpm

fix: 162df30

kou · 2025-10-15T08:19:23Z

packages/packages-groonga-org-package-task.rb

+    end
+  end
+
+  def remove_srpm_from_arm_architectures


Suggested change

def remove_srpm_from_arm_architectures

def remove_srpm_from_non_primary_architectures

fix: 4dfee33

…architecture

otegami · 2025-10-15T10:13:30Z

Thank you for the reviews. I’ve addressed all the comments so far.

packages/packages-groonga-org-package-task.rb

otegami force-pushed the rename-yum-srpm-path branch 4 times, most recently from 82c5328 to 7c36b73 Compare October 10, 2025 10:57

otegami force-pushed the rename-yum-srpm-path branch from 7c36b73 to 5e0869f Compare October 12, 2025 07:50

otegami marked this pull request as ready for review October 12, 2025 08:57

kou reviewed Oct 12, 2025

View reviewed changes

otegami added 4 commits October 14, 2025 09:36

clarify the target distributions

af2933d

separate the logic of removing srpm files because it's not related to…

a70ed92

… backward compatibility

use *_path for consistency

15485bb

rename the method to show what we do

81066b0

fix typo

ce5b45b

- achitectures + architectures

otegami force-pushed the rename-yum-srpm-path branch from f71e64c to 4625aee Compare October 14, 2025 02:56

remove duplicated loops

e015dc0

otegami force-pushed the rename-yum-srpm-path branch from 4625aee to e015dc0 Compare October 14, 2025 03:08

Revert "remove duplicated loops"

22db6ba

This reverts commit e015dc0. We don't have to persue the speed here because there are not a lot of distibutions. Readability is more important.

kou reviewed Oct 14, 2025

View reviewed changes

otegami added 2 commits October 14, 2025 14:25

fix typo

013e311

- description + distribution

clarify we want to remove SRPM except for x86 architecture

2c13cb2

abetomo requested a review from Copilot October 14, 2025 23:50

Copilot AI reviewed Oct 14, 2025

View reviewed changes

rename it because it's much easier to know why we use the old path

96fc07b

kou reviewed Oct 15, 2025

View reviewed changes

add yum_ prefix because it's for only yum repositories

1ca7a60

otegami added 2 commits October 15, 2025 17:56

Use SRPM path as-is because this path is just new in this moment.

162df30

rename the method name because we want to remove SRPM except for x86 …

4dfee33

…architecture

otegami changed the title ~~package yum: manage SRPM paths for backward compatibility~~ package yum: keep SRPM paths for backward compatibility Oct 15, 2025

kou reviewed Oct 15, 2025

View reviewed changes

packages/packages-groonga-org-package-task.rb Outdated Show resolved Hide resolved

Add separator

92457db

kou merged commit 31ab0f0 into groonga:main Oct 15, 2025
2 checks passed

kou deleted the rename-yum-srpm-path branch October 15, 2025 12:01

	def yum_targets_default
	[
	"almalinux-8",
	"almalinux-8-aarch64",
	"almalinux-9",
	"almalinux-9-aarch64",
	"almalinux-10",
	"almalinux-10-aarch64",
	"amazon-linux-2023",
	"amazon-linux-2023-aarch64",
	]
	end

-      # Backward compatibility: only rename for existing distributions that
-      # still expect the legacy SRPM structure.
-      # Legacy (<= AlmaLinux 10): source/SRPMS
-      # New    (>= AlmaLinux 11): Source/Packages (no rename needed)
-      next if distribution != "almalinux"
+      # Rename SRPM directory only for the following distributions
+      # to keep backward compatibility:
+      #
+      # * AlmaLinux 8
+      # * AlmaLinux 9
+      # * AlmaLinux 10
+      # * Amazon Linux 2023
+      #
+      # They keep using source/SRPMS/*.src.rpm for SRPM path.
+      case "#{distribution}-#{version}"
+      when "almalinux-8",
+           "almalinux-9",
+           "almalinux-10",
+           "amazon-linux-2023"
+         next
+       end

		keep_srpm_paths_for_compatibility
		remove_srpm_from_arm_architectures

	# Use latest SRPM path for other distributions Source/Packages/*.src.rpm
	# Use SRPM path as-is for other distributions: Source/Packages/*.src.rpm

	def remove_srpm_from_arm_architectures
	def remove_srpm_from_non_primary_architectures

Conversation

otegami commented Oct 10, 2025 • edited by kou Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

otegami commented Oct 12, 2025

Before this PR

After this PR

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

otegami commented Oct 14, 2025

Uh oh!

otegami commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

otegami commented Oct 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

otegami commented Oct 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

otegami Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

otegami commented Oct 15, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

otegami commented Oct 10, 2025 •

edited by kou

Loading

otegami commented Oct 14, 2025 •

edited

Loading

otegami Oct 15, 2025 •

edited

Loading