Repository navigation
Conversation
The command declares --force as "Skip the interactive yes/no prompt for confirmation" and guards two of its three confirmations with it, but the PHP version warning prompts unconditionally. A run with --force still stops at "Are you sure you wish to continue?" and aborts, so the command cannot be run unattended on any PHP build whose version string is below 8.3.21 or 8.4.7 - which includes the official Docker image, since it installs Ubuntu 24.04's distro php8.3 packages. --no-interaction does not help either: Laravel's confirm() defaults to false, so it returns the default and lands on the same ABORTING branch. Guard that confirmation the same way as the other two. The warning itself still prints under --force, so the caveat stays visible in unattended logs.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Member
|
This looks great, thank you! |
kratos0718
added a commit
to kratos0718/portfolio
that referenced
this pull request
Sep 20, 2026
Merged-PR stat was showing 17 while the actual count is 22 - the OpenSource.tsx list was missing mercari/pipeline#122, apache/maven- help-plugin#424, grokability/snipe-it#19514, phasespace-labs/ palinode#132, and the newly-merged apache/maven-shared-jar#165. Added all five with real quotes/stars pulled from each PR, and updated the Landing and OpenSource stat badges and bio/tagline text in portfolioData.ts to match.
kratos0718
added a commit
to kratos0718/portfolio
that referenced
this pull request
Nov 12, 2026
Merged-PR stat was showing 17 while the actual count is 22 - the OpenSource.tsx list was missing mercari/pipeline#122, apache/maven- help-plugin#424, grokability/snipe-it#19514, phasespace-labs/ palinode#132, and the newly-merged apache/maven-shared-jar#165. Added all five with real quotes/stars pulled from each PR, and updated the Landing and OpenSource stat badges and bio/tagline text in portfolioData.ts to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported in #19513.
Problem
ldap:troubleshootdeclares--forceas "Skip the interactive yes/no prompt for confirmation" and guards two of its three confirmations with it:The PHP-version confirmation isn't guarded, so it prompts even with
--force:The practical effect, from the report:
--no-interactionisn't a way out either — Laravel'sconfirm($question, $default = false)returns the default under-n, which lands on the sameABORTINGbranch.This isn't an edge case for the official image: the Dockerfile is
FROM ubuntu:24.04installing distrophp8.3-*packages, and Ubuntu ships the 8.3.6 line with fixes backported rather than the version string advanced. So the check compares an upstream version number against a distro-patched build and fires on every run of that image, making the command unusable unattended there.Fix
Guard that confirmation the same way as the other two, in the same shape the file already uses. The
warn()is deliberately left outside the guard so the caveat still appears in unattended logs —--forcesuppresses the prompt, not the warning.Testing
php -lclean.The behavioural change, with
confirm()stubbed to what a non-interactive run returns:So the un-forced path is untouched and only
--forcechanges, which is the documented contract. I don't have an LDAP directory to exercise the rest of the command against, so this is scoped strictly to the guard.The reporter also raised whether the image should ship a newer PHP (they mentioned trying the Ondřej PPA) — that's a separate packaging decision, so I've left it out of this PR.