Replace OMP reductions by thread-private variables + critical#79
Merged
marvinfriede merged 2 commits intomainfrom Apr 2, 2025
Merged
Replace OMP reductions by thread-private variables + critical#79marvinfriede merged 2 commits intomainfrom
marvinfriede merged 2 commits intomainfrom
Conversation
thfroitzheim
approved these changes
Apr 2, 2025
This was referenced Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace reductions on arrays, which can lead to stack overflow errors for large(r) arrays. Reductions on arrays usually require increasing both
OMP_STACKSIZEfor the worker threads, but also settingulimit -s unlimitedto allow the stack size of the main thread to grow beyond the limit set upon starting the process. This is because reductions put the arrays on the stack, not on the heap.We avoid this by creating private copies on the heap for each thread and add up all copies after the loop in a
criticalsection, effectively emulating the reduction.