Change: Improve error handling of all exists() API methods

n-thumann · greenbonebot · commit d9b27e4a4939 · 2025-06-24T11:38:21.000+02:00
diff --git a/pontos/github/api/branch.py b/pontos/github/api/branch.py
@@ -287,7 +287,15 @@ async def exists(self, repo: str, branch: str) -> bool:
         """
         api = f"/repos/{repo}/branches/{branch}"
         response = await self._client.get(api)
-        return response.is_success
+
+        if response.is_success:
+            return True
+
+        if response.status_code == 404:
+            return False
+
+        response.raise_for_status()
+        assert False, "unreachable"  # assert to silence mypy
 
     async def delete(self, repo: str, branch: str) -> None:
         """
diff --git a/pontos/github/api/organizations.py b/pontos/github/api/organizations.py
@@ -39,7 +39,15 @@ async def exists(self, organization: str) -> bool:
         """
         api = f"/orgs/{organization}"
         response = await self._client.get(api)
-        return response.is_success
+
+        if response.is_success:
+            return True
+
+        if response.status_code == 404:
+            return False
+
+        response.raise_for_status()
+        assert False, "unreachable"  # assert to silence mypy
 
     async def get_repositories(
         self,
diff --git a/pontos/github/api/packages.py b/pontos/github/api/packages.py
@@ -33,7 +33,15 @@ async def exists(
         """
         api = f"/orgs/{organization}/packages/{package_type}/{package_name}"
         response = await self._client.get(api)
-        return response.is_success
+
+        if response.is_success:
+            return True
+
+        if response.status_code == 404:
+            return False
+
+        response.raise_for_status()
+        assert False, "unreachable"  # assert to silence mypy
 
     async def package(
         self, organization: str, package_type: PackageType, package_name: str
diff --git a/pontos/github/api/pull_requests.py b/pontos/github/api/pull_requests.py
@@ -39,7 +39,15 @@ async def exists(self, repo: str, pull_request: Union[int, str]) -> bool:
         """
         api = f"/repos/{repo}/pulls/{pull_request}"
         response = await self._client.get(api)
-        return response.is_success
+
+        if response.is_success:
+            return True
+
+        if response.status_code == 404:
+            return False
+
+        response.raise_for_status()
+        assert False, "unreachable"  # assert to silence mypy
 
     async def get(
         self, repo: str, pull_request: Union[int, str]
diff --git a/pontos/github/api/release.py b/pontos/github/api/release.py
@@ -102,7 +102,15 @@ async def exists(self, repo: str, tag: str) -> bool:
         """
         api = f"/repos/{repo}/releases/tags/{tag}"
         response = await self._client.get(api)
-        return response.is_success
+
+        if response.is_success:
+            return True
+
+        if response.status_code == 404:
+            return False
+
+        response.raise_for_status()
+        assert False, "unreachable"  # assert to silence mypy
 
     async def get(self, repo: str, tag: str) -> Release:
         """
