Skip to content

Comments

Remove Credential allow insecure use "Feature"#4971

Merged
greenbonebot merged 1 commit intomainfrom
remove-allow-insecure-use
Nov 24, 2025
Merged

Remove Credential allow insecure use "Feature"#4971
greenbonebot merged 1 commit intomainfrom
remove-allow-insecure-use

Conversation

@bjoernricks
Copy link
Contributor

What

Remove Credential allow insecure use "Feature"

Why

The feature was never implemented and therefore the switch is not necessary, confusing and obsolete.

References

https://jira.greenbone.net/browse/GEA-1297

Checklist

  • Tests

@bjoernricks bjoernricks requested a review from a team as a code owner November 20, 2025 11:25
@greenbonebot greenbonebot enabled auto-merge (rebase) November 20, 2025 11:25
@github-actions
Copy link

github-actions bot commented Nov 20, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA c45b655.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@bjoernricks bjoernricks force-pushed the remove-allow-insecure-use branch 2 times, most recently from b914ca8 to 21fae71 Compare November 20, 2025 12:19
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.49%. Comparing base (0ff3fd9) to head (c45b655).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4971      +/-   ##
==========================================
- Coverage   69.49%   69.49%   -0.01%     
==========================================
  Files        1148     1148              
  Lines      106834   106794      -40     
  Branches     8386     8382       -4     
==========================================
- Hits        74246    74212      -34     
+ Misses      32548    32542       -6     
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The feature was never implemented and therefore the switch is not
necessary, confusing and obsolete.
@bjoernricks bjoernricks force-pushed the remove-allow-insecure-use branch from 21fae71 to c45b655 Compare November 24, 2025 12:46
@greenbonebot greenbonebot merged commit 3a85a8a into main Nov 24, 2025
22 checks passed
@greenbonebot greenbonebot deleted the remove-allow-insecure-use branch November 24, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants