Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Deprecates and removes the PHP rule GCI66 (“AvoidDoubleQuoteCheck”) and its related tests, updates the rule repository registration, bumps the rules-specifications version, and logs the deletion.
- Removed the
AvoidDoubleQuoteCheckimplementation and its test resources - Deleted the rule from the
PhpRuleRepositoryannotated list - Bumped
creedengo-rules-specifications.versionin the POM and updated the changelog entry
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/resources/checks/AvoidDoubleQuote.php | Removed test PHP file containing double-quote rule examples |
| src/test/java/fr/greencodeinitiative/php/checks/AvoidDoubleQuoteCheckTest.java | Deleted the unit test for the deprecated rule |
| src/main/java/fr/greencodeinitiative/php/checks/AvoidDoubleQuoteCheck.java | Deleted the rule implementation for GCI66 |
| src/main/java/fr/greencodeinitiative/php/PhpRuleRepository.java | Removed AvoidDoubleQuoteCheck from the rule registration list |
| pom.xml | Updated <creedengo-rules-specifications.version> from 2.0.0 to 2.3.0 |
| CHANGELOG.md | Added entry for deprecation and removal of GCI66 |
Comments suppressed due to low confidence (1)
CHANGELOG.md:16
- This entry isn’t placed under a specific version heading; consider adding a new release section (e.g.,
## [2.0.2] - YYYY-MM-DD) above it to keep the changelog structure consistent.
- [#58](https://github.com/green-code-initiative/creedengo-php/issues/58) Deprecation and deletion of GCI66 rule for PHP
utarwyn
previously approved these changes
Jul 14, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.