Skip to content

[Challenge-25][GCI69][S.T.E.P] Enumeration false positive#103

Merged
dedece35 merged 7 commits intogreen-code-initiative:mainfrom
max-208:69-java
Jul 14, 2025
Merged

[Challenge-25][GCI69][S.T.E.P] Enumeration false positive#103
dedece35 merged 7 commits intogreen-code-initiative:mainfrom
max-208:69-java

Conversation

@max-208
Copy link
Copy Markdown
Contributor

@max-208 max-208 commented May 20, 2025

remove false positive for Enumeration with rule GCI69

@max-208
Copy link
Copy Markdown
Contributor Author

max-208 commented May 20, 2025

see rules spec #396

@JulienPlanque
Copy link
Copy Markdown

The mvn clean install return a compile error on NoFunctionCallWhenDeclaringForLoop.java is it\test-project folder.

@max-208
Copy link
Copy Markdown
Contributor Author

max-208 commented May 21, 2025

@JulienPlanque it should be ok now

@max-208 max-208 changed the title [Challenge-25][GCI69] Enumeration false positive [Challenge-25][GCI69][S.T.E.P] Enumeration false positive May 21, 2025
JulienPlanque
JulienPlanque previously approved these changes May 21, 2025
Copy link
Copy Markdown

@JulienPlanque JulienPlanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

utarwyn
utarwyn previously approved these changes May 23, 2025
@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jun 23, 2025
@dedece35 dedece35 merged commit d15d1ce into green-code-initiative:main Jul 14, 2025
1 check passed
@dedece35
Copy link
Copy Markdown
Member

Hi @max-208,
thank you for the good job !!!
It's a real improvement of this rule !

Hi @JulienPlanque and @utarwyn
thank you for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👀 👀 review done 👀 👀 review done - waiting for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants