Extend DjangoListField to use model queryset if none defined#732
Extend DjangoListField to use model queryset if none defined#732mvanlonden merged 4 commits intomasterfrom
Conversation
jkimbo
requested review from
dopeboy,
firaskafri,
mvanlonden,
phalt and
zbyte64
zbyte64
left a comment
zbyte64
left a comment
There was a problem hiding this comment.
I think most would people expect DjangoListField to connect the queryset automatically
|
Seeing as this PR already has been open for over a month and already has two approvals from eligible approvers, what's the hold-up with merging? I for one would find this immediately useful when released. |
This is an ongoing issue I have noticed with this project. PRs are getting raised to solve real issues, and are getting approved by 1 or 2 people but not the required 3. As such, It will likely discourage others from contributing. I would suggest lowering the required amount of approvals, to keep the project moving. |
|
This might be going a bit off-topic of this PR, but @McPo where did you find a mention of 3 approvals being required? I tried looking for PR policies on the |
At the bottom of the PRs it states X amount. Thought it stated more than 2, maybe they changed it? Or maybe Im just plain wrong. Regarding other PRs that I kept stumbling upon, there were several that had reviewers accepting it, but never they never hit the required amount. It wasn't just on this repo specifically, but across
Also to bring it a bit more on topic again (although its already been merged, cheers). I came to this issue due to a similar problem with get_node. Incase this helps anyone else in the future, the issue is #776 |
|
@McPo yep we changed the number of required reviewers to 2 (I think it was originally 3 some time ago). I agree with you that it should probably be reduced lower and I'll bring it up with the other maintainers when I next get the chance. |
7 participants
This PR extends the functionality for the
DjangoListFieldto use the default queryset on the Django model if no queryset is provided. This allows it to be used in the top level Query type.This PR also restricts the types that can be used with
DjangoListFieldto subclasses ofDjangoObjectType. I imagine that most people already only passDjangoObjectTypes toDjangoListFieldbut this just ensures it.