Check for filters defined on base filterset classes#730
Merged
jkimbo merged 4 commits intographql-python:masterfrom Aug 7, 2019
Merged
Check for filters defined on base filterset classes#730jkimbo merged 4 commits intographql-python:masterfrom
jkimbo merged 4 commits intographql-python:masterfrom
Conversation
Contributor
Author
|
@jkimbo I just updated the test so it uses the filter and checks for the proper article. Check it out and let me know if there is anything else I can do :) |
zbyte64
approved these changes
Aug 6, 2019
jkimbo
approved these changes
Aug 7, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #729, an issue with getting filter args from filtersets that have a base class with common filters, which was crashing.