bump graphiql to 0.13.0, and rename __debug to _debug#646
Merged
phalt merged 1 commit intographql-python:masterfrom May 20, 2019
dulmandakh:graphiql-0.13.0
Merged
bump graphiql to 0.13.0, and rename __debug to _debug#646phalt merged 1 commit intographql-python:masterfrom dulmandakh:graphiql-0.13.0
phalt merged 1 commit intographql-python:masterfrom
dulmandakh:graphiql-0.13.0
Conversation
4 similar comments
phalt
approved these changes
May 20, 2019
Contributor
phalt
left a comment
phalt
left a comment
There was a problem hiding this comment.
This looks good to me, as you're using this project from master you can attest to it working?
Contributor
Author
|
@phalt yep, it works for me. I'll open issues or create PRs if I encounter issues. |
Contributor
|
@dulmandakh thanks for this. I'll ear-mark it for being part of the 2.3 release (still getting the Graphene team to organise how to do this easier). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps graphiql to 0.13.0, the latest version available on JS CDN, and includes many improvements. And since 0.12 GraphQL prohibits to use names that starts with __, so renamed __debug to _debug. It works for me.
I use graphene-django from master.
fixes #640