Skip to content

Fix importing error for GraphQLTestCase#631

Merged
phalt merged 1 commit intomasterfrom
fix-628
May 13, 2019
Merged

Fix importing error for GraphQLTestCase#631
phalt merged 1 commit intomasterfrom
fix-628

Conversation

@phalt
Copy link
Copy Markdown
Contributor

@phalt phalt commented May 8, 2019

As mentioned in #628 you cannot import GraphQLTestCase, this is because the directory is excluded when published.

The best solution is to move this under utils and change the import. It's broken anyway.

Fixes #628

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.2%) to 92.712% when pulling 2bf7e7f on fix-628 into 223d0b1 on master.

3 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.2%) to 92.712% when pulling 2bf7e7f on fix-628 into 223d0b1 on master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.2%) to 92.712% when pulling 2bf7e7f on fix-628 into 223d0b1 on master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.2%) to 92.712% when pulling 2bf7e7f on fix-628 into 223d0b1 on master.

@phalt
Copy link
Copy Markdown
Contributor Author

phalt commented May 9, 2019

Going to ignore the coveralls on this as we're just shuffling around some code.

Copy link
Copy Markdown
Contributor

@GitRon GitRon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@phalt phalt merged commit e26a9f2 into master May 13, 2019
@phalt phalt deleted the fix-628 branch May 13, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot import graphene_django.tests.base_test.GraphQLTestCase

4 participants