Make DjangoDebugContext wait for nested fields#591
Merged
jkimbo merged 4 commits intographql-python:masterfrom Aug 7, 2019
Merged
Make DjangoDebugContext wait for nested fields#591jkimbo merged 4 commits intographql-python:masterfrom
jkimbo merged 4 commits intographql-python:masterfrom
Conversation
This commit makes DjangoDebugContext wait for all field's promises, even for fields that only started their resolvers after __debug was resolved. Fixes graphql-python#293.
|
why hasn't the checks completed for this pull request? |
|
What needs to happen for this to get merged? |
Collaborator
|
@ktosiek For whatever reason travis CI never built this PR. Please merge with master and push to re-trigger the build. |
2 similar comments
Contributor
Author
|
@zbyte64 thank you for the suggestion, it looks like the tests are passing now |
zbyte64
reviewed
Jun 3, 2019
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
mvanlonden
approved these changes
Aug 5, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes DjangoDebugContext wait for all field's promises, even for fields that only started their resolvers after __debug was resolved.
Fixes #293.