Always use HTTPS for CDN files#498
Merged
jkimbo merged 2 commits intographql-python:masterfrom Mar 19, 2019
Merged
Conversation
There's no point using insecure, deprecated HTTP even if the current page is on HTTP.
|
What about going one step further and adding the SHA hash of these js ? |
Contributor
Author
|
Forgot that's a thing now. I don't have the time to do it here. But it's not possible for two files as they are templated by version with |
Collaborator
|
@adamchainz I reckon it's worth doing for the other files, as it reduces the potential attack surface area. |
Contributor
Author
|
@danpalmer you're right |
firaskafri
approved these changes
Mar 19, 2019
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no point using insecure, deprecated HTTP even if the current page is on HTTP.