Skip to content

Pin an explicit version of django-filter (<2) on cookbook example#475

Merged
syrusakbary merged 1 commit intographql-python:masterfrom
NoumirPoutipou:master
Jul 24, 2018
Merged

Pin an explicit version of django-filter (<2) on cookbook example#475
syrusakbary merged 1 commit intographql-python:masterfrom
NoumirPoutipou:master

Conversation

@NoumirPoutipou
Copy link
Copy Markdown
Contributor

With requirements set with django-filter==0.11.0, the cookbook example is unable to execute query using filters. Leading to a TypeError :

__init__() got an unexpected keyword argument 'request'

Due to line 95 in filter/fields.py

Pin it to the same requirements as graphene-django itself.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 24, 2018

Coverage Status

Coverage increased (+0.2%) to 94.667% when pulling a57098b on NoumirPoutipou:master into dc561c6 on graphql-python:master.

@syrusakbary syrusakbary merged commit 52d14f3 into graphql-python:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants