Skip to content

Add @NullUnmarked to builders #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dondonz merged 3 commits into from
Aug 19, 2025
Merged

Add @NullUnmarked to builders #4087

dondonz merged 3 commits into from
Aug 19, 2025

Conversation

@dondonz
Copy link
Member

@dondonz dondonz commented Aug 17, 2025

Adding @NullUnmarked to a number of builders now that we've settled on this as a pattern

@dondonz dondonz added this to the 25.x breaking changes milestone Aug 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2025

Test Results

  326 files   -    652    326 suites   - 652   3m 34s ⏱️ - 7m 0s
5 022 tests  -    346  5 016 ✅  -    347  6 💤 + 1  0 ❌ ±0 
5 111 runs   - 10 222  5 105 ✅  - 10 211  6 💤  - 11  0 ❌ ±0 

Results for commit 0b63c84. ± Comparison against base commit 17dffdb.

This pull request removes 541 and adds 171 tests. Note that renamed tests count towards both. 
	?

	, expected: combo-\"\\\b\f\n\r\t, #4]
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
…

graphql.DataFetcherTest ‑ get Boolean property value [fetcher: <graphql.schema.PropertyDataFetcher@77ab22be propertyName=booleanField function=null>, #0]
graphql.DataFetcherTest ‑ get Boolean property value [fetcher: <graphql.schema.SingletonPropertyDataFetcher@1391af3b>, #1]
graphql.DataFetcherTest ‑ get Boolean property value with get [fetcher: <graphql.schema.PropertyDataFetcher@3a8d467e propertyName=booleanFieldWithGet function=null>, #0]
graphql.DataFetcherTest ‑ get Boolean property value with get [fetcher: <graphql.schema.SingletonPropertyDataFetcher@1391af3b>, #1]
graphql.DataFetcherTest ‑ get property value [fetcher: <graphql.schema.PropertyDataFetcher@49f40c00 propertyName=property function=null>, #0]
graphql.DataFetcherTest ‑ get property value [fetcher: <graphql.schema.SingletonPropertyDataFetcher@1391af3b>, #1]
graphql.DataFetcherTest ‑ get public field value as property [fetcher: <graphql.schema.PropertyDataFetcher@3ebe4ccc propertyName=publicField function=null>, #0]
graphql.DataFetcherTest ‑ get public field value as property [fetcher: <graphql.schema.SingletonPropertyDataFetcher@1391af3b>, #1]
graphql.ScalarsBooleanTest ‑ parseValue throws exception for invalid input <java.lang.Object@4888792b>
graphql.ScalarsBooleanTest ‑ serialize throws exception for invalid input <java.lang.Object@577ca7c3>
…
This pull request skips 1 test. 
graphql.schema.fetching.LambdaFetchingSupportTest ‑ different class loaders induce certain behaviours

@dondonz dondonz merged commit c842ed4 into master Aug 19, 2025
2 checks passed
@dondonz dondonz deleted the builders-nullity branch August 19, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andimarek andimarek andimarek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

25.x breaking changes

Development

Successfully merging this pull request may close these issues.

2 participants

@dondonz @andimarek