Intern field names #3489
Merged
Intern field names #3489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rumentation-context # Conflicts: # src/main/java/graphql/execution/ExecutionStrategy.java # src/main/java/graphql/execution/instrumentation/dataloader/FieldLevelTrackingApproach.java
…-key-objects Don't build a builder object and then turn it into the actual object
…-instrumentation-context This removes the CompletableFuture signature from InstrumentationContext
…-filter directive filtering during printing
DanielThomas
commented
Mar 1, 2024
| @Override | ||
| public List<GraphQLNamedOutputType> getInterfaces() { | ||
| if (replacedInterfaces != null) { | ||
| return ImmutableList.copyOf(replacedInterfaces); |
Contributor
Author
There was a problem hiding this comment.
These are already immutable, noticed while I was reviewing the changes.
DanielThomas
force-pushed
the
dannyt/intern-field-names
branch
from
7f4e4c5 to
9ee1f6a
Compare
bbakerman
added
the
performance
Member
|
I want to do some wteaks ot this PR so I am going to merge it in to this branch |
Member
|
Ahh shit... I stuffed up the branch starting point.... Hmmm |
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick follow up from #3478 to intern field names which allows object identity equality checks for
String.equalsand when looking up field definitions by name. Benchmark result here:#3478 (comment)