Skip to content

Async can now wait on materialized objects #3462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bbakerman wants to merge 3 commits into from
Closed

Async can now wait on materialized objects #3462

bbakerman wants to merge 3 commits into from

Conversation

@bbakerman
Copy link
Member

@bbakerman bbakerman commented Feb 20, 2024

This is a setup PR for later work. This allows Async to wait on materialised objects or CFs or a mix

This wont be used in the code today - all values will be CFs but this is setup work for the future

@bbakerman
Copy link
Member Author

bbakerman commented Feb 23, 2024 •
edited
Loading

after update with batchSize=100 - agained edited these numbers

before

Benchmark                      (numberOfFieldCFs)   Mode  Cnt       Score       Error  Units
AsyncBenchmark.benchmarkAsync                   1  thrpt    4  687152.037 ± 819652.858  ops/s
AsyncBenchmark.benchmarkAsync                   5  thrpt    4  158146.382 ±  13373.615  ops/s
AsyncBenchmark.benchmarkAsync                  20  thrpt    4   28521.619 ±   2698.366  ops/s

after

Benchmark                      (numberOfFieldCFs)   Mode  Cnt       Score       Error  Units
AsyncBenchmark.benchmarkAsync                   1  thrpt    4  580070.646 ± 83754.940  ops/s
AsyncBenchmark.benchmarkAsync                   5  thrpt    4  133897.900 ±  7252.349  ops/s
AsyncBenchmark.benchmarkAsync                  20  thrpt    4   28299.556 ± 28528.998  ops/s

@bbakerman bbakerman mentioned this pull request Feb 29, 2024
Merged
@bbakerman
Copy link
Member Author

bbakerman commented Mar 27, 2024

No longer needed - the co-dependent PRs brough in this code

@bbakerman bbakerman closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andimarek andimarek andimarek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

22.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bbakerman @andimarek