Minor performance fixes #3236
Merged
Minor performance fixes #3236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfa1
commented
May 30, 2023
| public ExecutionStepInfo newExecutionStepInfoForListElement(ExecutionStepInfo executionInfo, ResultPath indexedPath) { | ||
| GraphQLList fieldType = (GraphQLList) executionInfo.getUnwrappedNonNullType(); | ||
| GraphQLOutputType typeInList = (GraphQLOutputType) fieldType.getWrappedType(); | ||
| ResultPath indexedPath = executionInfo.getPath().segment(index); |
Contributor
Author
There was a problem hiding this comment.
according to my memory profiler, this is dropping from 3-4% of total heap to just 1-2% (as expected)
Member
There was a problem hiding this comment.
Just to explain to others - the indexedPath was allocated out side this method and then reallocated again here. This double allocation has been removed
Contributor
Author
|
master branch 110afe0 this branch: |
This is a breaking change because it is removal from a public API. However, the fields are not used.
bbakerman
reviewed
Jun 2, 2023
| @Internal | ||
| public class ExecutionStepInfoFactory { | ||
|
|
||
| public ExecutionStepInfo newExecutionStepInfoForSubField(ExecutionContext executionContext, MergedField mergedField, ExecutionStepInfo parentInfo) { |
Member
There was a problem hiding this comment.
just checked - code was never used
bbakerman
reviewed
Jun 2, 2023
| public int getCurrentListIndex() { | ||
| return currentListIndex; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
There are not used anywhere and are informational
bbakerman
approved these changes
Jun 2, 2023
Member
|
Thanks |
bbakerman
added
the
performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello @bbakerman @andimarek :)
another batch of small fixes... please have a look when you have time :)
D.